From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73924 invoked by alias); 26 Oct 2018 10:51:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25944 invoked by uid 89); 26 Oct 2018 10:47:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Oct 2018 10:47:48 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9552E31500BC; Fri, 26 Oct 2018 10:47:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE20865F4D; Fri, 26 Oct 2018 10:47:46 +0000 (UTC) Subject: Re: [RFA] Removes a bunch of usages of gdb_suppress_tests in 'runto_main' To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20181025205832.15248-1-philippe.waroquiers@skynet.be> From: Pedro Alves Message-ID: Date: Fri, 26 Oct 2018 10:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181025205832.15248-1-philippe.waroquiers@skynet.be> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00616.txt.bz2 Wow, thanks! "removes" -> "remove" in subject. On 10/25/2018 09:58 PM, Philippe Waroquiers wrote: > In the 'info -q -t' patch series, I started a new test from > gdb.threads/threadapply.exp, that uses an obsolete way to do > runto_main. > > This patch changes all occurences of runto_main using gdb_suppress_tests occurences -> occurrences > to use instead fail+return. > > Note that there are still about 220 occurences of gdb_suppress_tests Ditto. > but unclear (to me) if these can be similarly trivially be replaced by a > fail+return. Further cleanup can be done in follow-up patches. Certainly! > > Tests run on Debian/x86_64. > > gdb/testsuite/ChangeLog > 2018-10-25 Philippe Waroquiers > > * gdb.arch/altivec-regs.exp: Do not use gdb_suppress_tests in > runto_main, use fail + return instead. > gdb.arch/amd64-byte.exp: Likewise. > gdb.arch/amd64-dword.exp: Likewise. > gdb.arch/amd64-word.exp: Likewise. > gdb.arch/e500-abi.exp: Likewise. > gdb.arch/e500-regs.exp: Likewise. > gdb.arch/gdb1291.exp: Likewise. > gdb.arch/gdb1431.exp: Likewise. > gdb.arch/i386-avx.exp: Likewise. > gdb.arch/i386-byte.exp: Likewise. > gdb.arch/i386-prologue.exp: Likewise. > gdb.arch/i386-sse.exp: Likewise. > gdb.arch/i386-word.exp: Likewise. > gdb.arch/iwmmxt-regs.exp: Likewise. > gdb.arch/pa-nullify.exp: Likewise. > gdb.arch/powerpc-prologue.exp: Likewise. > gdb.arch/s390-tdbregs.exp: Likewise. > gdb.arch/vsx-regs.exp: Likewise. > gdb.asm/asm-source.exp: Likewise. > gdb.base/auxv.exp: Likewise. > gdb.base/bigcore.exp: Likewise. > gdb.base/overlays.exp: Likewise. > gdb.base/savedregs.exp: Likewise. > gdb.base/setshow.exp: Likewise. > gdb.base/sigaltstack.exp: Likewise. > gdb.base/sigbpt.exp: Likewise. > gdb.base/siginfo-addr.exp: Likewise. > gdb.base/siginfo-obj.exp: Likewise. > gdb.base/siginfo-thread.exp: Likewise. > gdb.base/siginfo.exp: Likewise. > gdb.base/signull.exp: Likewise. > gdb.base/sigrepeat.exp: Likewise. > gdb.base/structs2.exp: Likewise. > gdb.threads/threadapply.exp: Likewise. > gdb.threads/watchthreads.exp: Likewise. > gdb.threads/watchthreads2.exp: Likewise. OK. Thanks, Pedro Alves