From: Simon Marchi <simon.marchi@polymtl.ca>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Fix mem region parsing regression and add test
Date: Tue, 14 Nov 2017 21:43:00 -0000 [thread overview]
Message-ID: <db5140e8f69da10f6c5c18b61bb99edd@polymtl.ca> (raw)
In-Reply-To: <1510269503-12483-2-git-send-email-simon.marchi@ericsson.com>
On 2017-11-09 18:18, Simon Marchi wrote:
> In my patch
>
> Get rid of VEC (mem_region)
> a664f67e50eff30198097d51cec0ec4690abb2a1
>
> I introduced a regression, where the length of the memory region is
> assigned to the "hi" field. It should obviously be computed as "start
> +
> length". To my defense, no test had caught this :). As a penance, I
> wrote one.
I have pushed this patch (2/2), since it's a bug fix and I don't want to
forget it. Patch 1/2 is still up for review, especially the part about
updating the file on the website.
Simon
next prev parent reply other threads:[~2017-11-14 21:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 23:18 [PATCH 1/2] Fix issues with gdb-memory-map.dtd Simon Marchi
2017-11-09 23:18 ` [PATCH 2/2] Fix mem region parsing regression and add test Simon Marchi
2017-11-14 21:43 ` Simon Marchi [this message]
2017-11-10 8:01 ` [PATCH 1/2] Fix issues with gdb-memory-map.dtd Eli Zaretskii
2017-11-10 21:01 ` Simon Marchi
2017-11-24 16:31 ` Simon Marchi
2017-11-24 21:30 ` Joel Brobecker
2017-11-24 21:35 ` Simon Marchi
2017-11-24 21:57 ` Joel Brobecker
2017-11-24 22:15 ` Simon Marchi
2017-11-24 22:23 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db5140e8f69da10f6c5c18b61bb99edd@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox