From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34549 invoked by alias); 14 Nov 2017 21:43:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34535 invoked by uid 89); 14 Nov 2017 21:43:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 spammy=defense, website X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Nov 2017 21:43:53 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vAELhifS013553 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 14 Nov 2017 16:43:49 -0500 Received: by simark.ca (Postfix, from userid 112) id 8A0901E586; Tue, 14 Nov 2017 16:43:44 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 657191E030; Tue, 14 Nov 2017 16:43:43 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 14 Nov 2017 21:43:00 -0000 From: Simon Marchi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Fix mem region parsing regression and add test In-Reply-To: <1510269503-12483-2-git-send-email-simon.marchi@ericsson.com> References: <1510269503-12483-1-git-send-email-simon.marchi@ericsson.com> <1510269503-12483-2-git-send-email-simon.marchi@ericsson.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 14 Nov 2017 21:43:44 +0000 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00258.txt.bz2 On 2017-11-09 18:18, Simon Marchi wrote: > In my patch > > Get rid of VEC (mem_region) > a664f67e50eff30198097d51cec0ec4690abb2a1 > > I introduced a regression, where the length of the memory region is > assigned to the "hi" field. It should obviously be computed as "start > + > length". To my defense, no test had caught this :). As a penance, I > wrote one. I have pushed this patch (2/2), since it's a bug fix and I don't want to forget it. Patch 1/2 is still up for review, especially the part about updating the file on the website. Simon