From: Pedro Alves <palves@redhat.com>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Fix target_supports_scheduler_locking raciness
Date: Tue, 09 Oct 2018 12:58:00 -0000 [thread overview]
Message-ID: <dafc5935-4ae1-cd79-5adb-7cb13dd23aa5@redhat.com> (raw)
In-Reply-To: <20181004174015.GA20307@delia>
On 10/04/2018 06:40 PM, Tom de Vries wrote:
> Hi,
>
> When calling gdb_start_cmd, it's the caller's responsibility to wait for gdb
> to return to the prompt. In target_supports_scheduler_locking, that's not the
> case, and consequently, target_supports_scheduler_locking fails spuriously.
>
> Fix by using runto_main instead.
>
> Build and reg-tested on x86_64-linux.
>
> OK for trunk?
The fix itself it OK. Thanks for doing that. Can you please
submit the gdb-caching-proc.exp separately, with its own rationale?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-10-09 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 17:40 Tom de Vries
2018-10-09 12:58 ` Pedro Alves [this message]
2018-10-09 13:47 ` [gdb/testsuite] Add gdb-caching-proc.exp testcase Tom de Vries
2018-11-05 9:05 ` [PING][gdb/testsuite] " Tom de Vries
2018-11-30 19:49 ` [gdb/testsuite] " Tom Tromey
2018-12-01 8:04 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dafc5935-4ae1-cd79-5adb-7cb13dd23aa5@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox