From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64021 invoked by alias); 9 Oct 2018 12:58:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64007 invoked by uid 89); 9 Oct 2018 12:58:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 09 Oct 2018 12:58:28 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8EF9F80F7A; Tue, 9 Oct 2018 12:58:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECAB91001F41; Tue, 9 Oct 2018 12:58:26 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Fix target_supports_scheduler_locking raciness To: Tom de Vries , gdb-patches@sourceware.org References: <20181004174015.GA20307@delia> From: Pedro Alves Message-ID: Date: Tue, 09 Oct 2018 12:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181004174015.GA20307@delia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00207.txt.bz2 On 10/04/2018 06:40 PM, Tom de Vries wrote: > Hi, > > When calling gdb_start_cmd, it's the caller's responsibility to wait for gdb > to return to the prompt. In target_supports_scheduler_locking, that's not the > case, and consequently, target_supports_scheduler_locking fails spuriously. > > Fix by using runto_main instead. > > Build and reg-tested on x86_64-linux. > > OK for trunk? The fix itself it OK. Thanks for doing that. Can you please submit the gdb-caching-proc.exp separately, with its own rationale? Thanks, Pedro Alves