From: Hui Zhu <teawater@gmail.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [OB] comment and whitespace
Date: Tue, 08 Sep 2009 02:41:00 -0000 [thread overview]
Message-ID: <daef60380909071940h2d76d501y3f184c88c8febd81@mail.gmail.com> (raw)
In-Reply-To: <4AA5AA3E.9080408@vmware.com>
On Tue, Sep 8, 2009 at 08:50, Michael Snyder<msnyder@vmware.com> wrote:
> Checked in as obvious.
Thanks a lot.
Hui
>
>
> 2009-09-07 Michael Snyder <msnyder@vmware.com>
>
> * record.c: Minor comment and white space fix-ups.
>
> Index: record.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/record.c,v
> retrieving revision 1.16
> diff -u -p -r1.16 record.c
> --- record.c 2 Sep 2009 01:31:09 -0000 1.16
> +++ record.c 8 Sep 2009 00:49:41 -0000
> @@ -32,14 +32,16 @@
> #define RECORD_IS_REPLAY \
> (record_list->next || execution_direction == EXEC_REVERSE)
>
> -/* These are the core struct of record function.
> +/* These are the core structs of the process record functionality.
>
> - An record_entry is a record of the value change of a register
> + A record_entry is a record of the value change of a register
> ("record_reg") or a part of memory ("record_mem"). And each
> - instruction must has a struct record_entry ("record_end") that points
> out this
> - is the last struct record_entry of this instruction.
> + instruction must have a struct record_entry ("record_end") that
> + indicates that this is the last struct record_entry of this
> + instruction.
>
> - Each struct record_entry is linked to "record_list" by "prev" and
> "next". */
> + Each struct record_entry is linked to "record_list" by "prev" and
> + "next" pointers. */
>
> struct record_reg_entry
> {
> @@ -1288,15 +1290,15 @@ _initialize_record (void)
>
> /* Record instructions number limit command. */
> add_setshow_boolean_cmd ("stop-at-limit", no_class,
> - &record_stop_at_limit, _("\
> + &record_stop_at_limit, _("\
> Set whether record/replay stops when record/replay buffer becomes full."),
> _("\
> Show whether record/replay stops when record/replay buffer becomes full."),
> _("\
> Default is ON.\n\
> When ON, if the record/replay buffer becomes full, ask user what to do.\n\
> When OFF, if the record/replay buffer becomes full,\n\
> delete the oldest recorded instruction to make room for each new one."),
> - NULL, NULL,
> - &set_record_cmdlist, &show_record_cmdlist);
> + NULL, NULL,
> + &set_record_cmdlist, &show_record_cmdlist);
> add_setshow_zinteger_cmd ("insn-number-max", no_class,
> &record_insn_max_num,
> _("Set record/replay buffer limit."),
> @@ -1306,6 +1308,6 @@ record/replay buffer. Zero means unlimi
> set_record_insn_max_num,
> NULL, &set_record_cmdlist, &show_record_cmdlist);
> add_cmd ("insn-number", class_obscure, show_record_insn_number,
> - _("Show the current number of instructions in the "
> - "record/replay buffer."), &info_record_cmdlist);
> + _("Show the current number of instructions in the "
> + "record/replay buffer."), &info_record_cmdlist);
> }
>
>
prev parent reply other threads:[~2009-09-08 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 0:51 Michael Snyder
2009-09-08 2:41 ` Hui Zhu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380909071940h2d76d501y3f184c88c8febd81@mail.gmail.com \
--to=teawater@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox