From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6934 invoked by alias); 8 Sep 2009 02:41:31 -0000 Received: (qmail 6859 invoked by uid 22791); 8 Sep 2009 02:41:30 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail-px0-f180.google.com (HELO mail-px0-f180.google.com) (209.85.216.180) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Sep 2009 02:41:20 +0000 Received: by pxi10 with SMTP id 10so2732573pxi.24 for ; Mon, 07 Sep 2009 19:41:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.152.26 with SMTP id z26mr575136wfd.201.1252377679074; Mon, 07 Sep 2009 19:41:19 -0700 (PDT) In-Reply-To: <4AA5AA3E.9080408@vmware.com> References: <4AA5AA3E.9080408@vmware.com> From: Hui Zhu Date: Tue, 08 Sep 2009 02:41:00 -0000 Message-ID: Subject: Re: [OB] comment and whitespace To: Michael Snyder Cc: "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00181.txt.bz2 On Tue, Sep 8, 2009 at 08:50, Michael Snyder wrote: > Checked in as obvious. Thanks a lot. Hui > > > 2009-09-07 =A0Michael Snyder =A0 > > =A0 =A0 =A0 =A0* record.c: Minor comment and white space fix-ups. > > Index: record.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/record.c,v > retrieving revision 1.16 > diff -u -p -r1.16 record.c > --- record.c =A0 =A02 Sep 2009 01:31:09 -0000 =A0 =A0 =A0 1.16 > +++ record.c =A0 =A08 Sep 2009 00:49:41 -0000 > @@ -32,14 +32,16 @@ > =A0#define RECORD_IS_REPLAY \ > =A0 =A0 =A0(record_list->next || execution_direction =3D=3D EXEC_REVERSE) > > -/* These are the core struct of record function. > +/* These are the core structs of the process record functionality. > > - =A0 An record_entry is a record of the value change of a register > + =A0 A record_entry is a record of the value change of a register > =A0 =A0("record_reg") or a part of memory ("record_mem"). =A0And each > - =A0 instruction must has a struct record_entry ("record_end") that poin= ts > out this > - =A0 is the last struct record_entry of this instruction. > + =A0 instruction must have a struct record_entry ("record_end") that > + =A0 indicates that this is the last struct record_entry of this > + =A0 instruction. > > - =A0 Each struct record_entry is linked to "record_list" by "prev" and > "next". */ > + =A0 Each struct record_entry is linked to "record_list" by "prev" and > + =A0 "next" pointers. =A0*/ > > =A0struct record_reg_entry > =A0{ > @@ -1288,15 +1290,15 @@ _initialize_record (void) > > =A0 /* Record instructions number limit command. =A0*/ > =A0 add_setshow_boolean_cmd ("stop-at-limit", no_class, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &record_stop_at_lim= it, _("\ > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&record_stop_at_limi= t, _("\ > =A0Set whether record/replay stops when record/replay buffer becomes full= ."), > _("\ > =A0Show whether record/replay stops when record/replay buffer becomes ful= l."), > _("\ > =A0Default is ON.\n\ > =A0When ON, if the record/replay buffer becomes full, ask user what to do= .\n\ > =A0When OFF, if the record/replay buffer becomes full,\n\ > =A0delete the oldest recorded instruction to make room for each new one."= ), > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 NULL, NULL, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&set_record_cmdl= ist, &show_record_cmdlist); > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0NULL, NULL, > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&set_record_cmdlist,= &show_record_cmdlist); > =A0 add_setshow_zinteger_cmd ("insn-number-max", no_class, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&record_insn_max_n= um, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0_("Set record/repl= ay buffer limit."), > @@ -1306,6 +1308,6 @@ record/replay buffer. =A0Zero means unlimi > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0set_record_insn_ma= x_num, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0NULL, &set_record_= cmdlist, &show_record_cmdlist); > =A0 add_cmd ("insn-number", class_obscure, show_record_insn_number, > - =A0 =A0 =A0 =A0 =A0 _("Show the current number of instructions in the " > - =A0 =A0 =A0 =A0 =A0 =A0 "record/replay buffer."), &info_record_cmdlist); > + =A0 =A0 =A0 =A0 =A0_("Show the current number of instructions in the " > + =A0 =A0 =A0 =A0 =A0 =A0"record/replay buffer."), &info_record_cmdlist); > =A0} > >