Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Bug in i386_process_record
Date: Sun, 16 Aug 2009 18:55:00 -0000	[thread overview]
Message-ID: <daef60380908160912i17b99706p2b46fe93dd80579@mail.gmail.com> (raw)
In-Reply-To: <4A875C26.7060302@vmware.com>

	case 0x67:
	  prefixes |= PREFIX_ADDR;
	  break;
        case 0x40:
        case 0x41:
        case 0x42:
        case 0x43:
        case 0x44:
        case 0x45:
        case 0x46:
        case 0x47:

      /* inv */
    case 0x40:
    case 0x41:
    case 0x42:
    case 0x43:
    case 0x44:
    case 0x45:
    case 0x46:
    case 0x47:

Oops, I must make something wrong.  I need check the spec of amd64 clear.

Thanks,
Hui

On Sun, Aug 16, 2009 at 09:08, Michael Snyder<msnyder@vmware.com> wrote:
> Hi Hui,
>
> This line in i386-tdep.c causes 4 failures in machinestate.exp.
>
> diff -u -p -r1.283 i386-tdep.c
> --- i386-tdep.c 10 Aug 2009 03:02:39 -0000      1.283
> +++ i386-tdep.c 16 Aug 2009 01:07:48 -0000
> @@ -3283,7 +3283,7 @@ i386_process_record (struct gdbarch *gdb
>         case 0x40:
>         case 0x41:
>         case 0x42:
> -        case 0x43:
> +         //        case 0x43:
>         case 0x44:
>         case 0x45:
>         case 0x46:
>
> 0x43 is "inc %ebx", and this line causes it to be treated as a prefix,
> consuming the instruction without recording the register change.
>
> I don't want to change it myself, because I'm not sure what other
> side effects the change might have.  Could you fix it please?  ;-)
>
> Thanks,
> Michael
>
>


  reply	other threads:[~2009-08-16 16:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-16 12:45 Michael Snyder
2009-08-16 18:55 ` Hui Zhu [this message]
2009-08-17  6:36   ` Hui Zhu
2009-08-17 14:37     ` Hui Zhu
2009-08-17 18:34       ` Michael Snyder
2009-08-18  3:03         ` Hui Zhu
2009-08-18  9:11           ` Hui Zhu
2009-08-18  9:22             ` Hui Zhu
2009-08-17 18:17     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380908160912i17b99706p2b46fe93dd80579@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox