From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66022-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32714 invoked by alias); 16 Aug 2009 16:12:44 -0000
Received: (qmail 32706 invoked by uid 22791); 16 Aug 2009 16:12:43 -0000
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-pz0-f197.google.com (HELO mail-pz0-f197.google.com) (209.85.222.197)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 16 Aug 2009 16:12:39 +0000
Received: by pzk35 with SMTP id 35so1819553pzk.24         for <gdb-patches@sourceware.org>; Sun, 16 Aug 2009 09:12:37 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.142.196.1 with SMTP id t1mr499160wff.25.1250439156130; Sun, 16  	Aug 2009 09:12:36 -0700 (PDT)
In-Reply-To: <4A875C26.7060302@vmware.com>
References: <4A875C26.7060302@vmware.com>
From: Hui Zhu <teawater@gmail.com>
Date: Sun, 16 Aug 2009 18:55:00 -0000
Message-ID: <daef60380908160912i17b99706p2b46fe93dd80579@mail.gmail.com>
Subject: Re: Bug in i386_process_record
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00221.txt.bz2

	case 0x67:
	  prefixes |=3D PREFIX_ADDR;
	  break;
        case 0x40:
        case 0x41:
        case 0x42:
        case 0x43:
        case 0x44:
        case 0x45:
        case 0x46:
        case 0x47:

      /* inv */
    case 0x40:
    case 0x41:
    case 0x42:
    case 0x43:
    case 0x44:
    case 0x45:
    case 0x46:
    case 0x47:

Oops, I must make something wrong.  I need check the spec of amd64 clear.

Thanks,
Hui

On Sun, Aug 16, 2009 at 09:08, Michael Snyder<msnyder@vmware.com> wrote:
> Hi Hui,
>
> This line in i386-tdep.c causes 4 failures in machinestate.exp.
>
> diff -u -p -r1.283 i386-tdep.c
> --- i386-tdep.c 10 Aug 2009 03:02:39 -0000 =A0 =A0 =A01.283
> +++ i386-tdep.c 16 Aug 2009 01:07:48 -0000
> @@ -3283,7 +3283,7 @@ i386_process_record (struct gdbarch *gdb
> =A0 =A0 =A0 =A0 case 0x40:
> =A0 =A0 =A0 =A0 case 0x41:
> =A0 =A0 =A0 =A0 case 0x42:
> - =A0 =A0 =A0 =A0case 0x43:
> + =A0 =A0 =A0 =A0 // =A0 =A0 =A0 =A0case 0x43:
> =A0 =A0 =A0 =A0 case 0x44:
> =A0 =A0 =A0 =A0 case 0x45:
> =A0 =A0 =A0 =A0 case 0x46:
>
> 0x43 is "inc %ebx", and this line causes it to be treated as a prefix,
> consuming the instruction without recording the register change.
>
> I don't want to change it myself, because I'm not sure what other
> side effects the change might have. =A0Could you fix it please? =A0;-)
>
> Thanks,
> Michael
>
>