Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, msnyder@vmware.com
Subject: Re: Process record and replay checked in to main trunk
Date: Fri, 01 May 2009 17:08:00 -0000	[thread overview]
Message-ID: <daef60380905011008r416b098ei29c43ca4b0a81267@mail.gmail.com> (raw)
In-Reply-To: <831vr9dvhc.fsf@gnu.org>

That is very good for me.
Thanks.

Hui

On Fri, May 1, 2009 at 17:26, Eli Zaretskii <eliz@gnu.org> wrote:
> May I suggest the following changes in some of the doc strings related
> to this feature?  In addition to rewording, it also reformats the way
> the strings are presented, so that it is easy to spot when we exceed
> the width of the screen and need to break long lines.
>
> 2009-05-01  Eli Zaretskii  <eliz@gnu.org>
>
>        * record.c (_initialize_record): Reformat and clarify doc strings
>        for stop-at-limit and insn-number-max.
>
> Index: gdb/record.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/record.c,v
> retrieving revision 1.2
> diff -u -r1.2 record.c
> --- gdb/record.c        30 Apr 2009 02:58:37 -0000      1.2
> +++ gdb/record.c        1 May 2009 09:24:01 -0000
> @@ -1259,28 +1259,21 @@
>
>   /* Record instructions number limit command.  */
>   add_setshow_boolean_cmd ("stop-at-limit", no_class,
> -                           &record_stop_at_limit,
> -                           _("Set whether record/replay stop when "
> -                             "record/replay buffer becomes full."),
> -                           _("Show whether record/replay stop when "
> -                             "record/replay buffer becomes full."),
> -                           _("Enable is default value.\n"
> -                             "When enabled, if the record/replay buffer "
> -                             "becomes full,\n"
> -                              "ask user what to do.\n"
> -                              "When disabled, if the record/replay buffer "
> -                             "becomes full,\n"
> -                              "delete it and start new recording."),
> +                           &record_stop_at_limit, _("\
> +Set whether record/replay stops when record/replay buffer becomes full."), _("\
> +Show whether record/replay stops when record/replay buffer becomes full."), _("\
> +Default is ON.\n\
> +When ON, if the record/replay buffer becomes full, ask user what to do.\n\
> +When OFF, if the record/replay buffer becomes full,\n\
> +delete the oldest recorded instruction to make room for each new one."),
>                            NULL, NULL,
>                             &set_record_cmdlist, &show_record_cmdlist);
>   add_setshow_zinteger_cmd ("insn-number-max", no_class,
>                            &record_insn_max_num,
>                            _("Set record/replay buffer limit."),
> -                           _("Show record/replay buffer limit."),
> -                           _("Set the maximum number of instructions to be "
> -                              "stored in the\n"
> -                              "record/replay buffer.  "
> -                              "Zero means unlimited (default 200000)."),
> +                           _("Show record/replay buffer limit."), _("\
> +Set the maximum number of instructions to be stored in the\n\
> +record/replay buffer.  Zero means unlimited.  Default is 200000."),
>                            set_record_insn_max_num,
>                            NULL, &set_record_cmdlist, &show_record_cmdlist);
>   add_cmd ("insn-number", class_obscure, show_record_insn_number,
>


  reply	other threads:[~2009-05-01 17:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-30  7:59 Hui Zhu
2009-04-30 14:43 ` Marc Khouzam
2009-04-30 20:00   ` Michael Snyder
2009-05-01  9:16 ` Eli Zaretskii
2009-05-01 17:02   ` Hui Zhu
2009-05-01 17:55     ` Eli Zaretskii
2009-05-03 14:15       ` Hui Zhu
2009-05-04 11:17         ` Eli Zaretskii
2009-05-04 16:46           ` Michael Snyder
2009-05-05 13:48           ` Hui Zhu
2009-05-04 14:32         ` Marc Khouzam
2009-05-04 16:46           ` Eli Zaretskii
2009-05-05 14:11           ` Hui Zhu
2009-05-01  9:26 ` Eli Zaretskii
2009-05-01 17:08   ` Hui Zhu [this message]
2009-05-01 17:58     ` Eli Zaretskii
2009-05-01 13:28 ` Eli Zaretskii
2009-05-03 13:54   ` Hui Zhu
2009-05-04 11:15     ` Eli Zaretskii
2009-05-05 13:40       ` Hui Zhu
2009-05-05 19:01         ` Eli Zaretskii
2009-05-05 19:32           ` Mark Kettenis
2009-05-05 19:52             ` Eli Zaretskii
2009-05-06 13:34               ` Hui Zhu
     [not found] ` <daef60380904300102o4470ac45he41f6b72176b1947@mail.gmail.com>
2009-05-07 22:24   ` Pierre Muller
2009-05-07 22:52     ` Michael Snyder
2009-05-07 23:05       ` Pedro Alves
2009-05-08  5:12         ` Hui Zhu
2009-05-08 12:11           ` Pierre Muller
2009-05-10 17:28             ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=daef60380905011008r416b098ei29c43ca4b0a81267@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox