From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10406 invoked by alias); 1 May 2009 17:08:58 -0000 Received: (qmail 10396 invoked by uid 22791); 1 May 2009 17:08:57 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.184) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 May 2009 17:08:52 +0000 Received: by ti-out-0910.google.com with SMTP id a1so249815tib.12 for ; Fri, 01 May 2009 10:08:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.110.92.8 with SMTP id p8mr220373tib.56.1241197728903; Fri, 01 May 2009 10:08:48 -0700 (PDT) In-Reply-To: <831vr9dvhc.fsf@gnu.org> References: <831vr9dvhc.fsf@gnu.org> Date: Fri, 01 May 2009 17:08:00 -0000 Message-ID: Subject: Re: Process record and replay checked in to main trunk From: Hui Zhu To: Eli Zaretskii Cc: gdb-patches@sourceware.org, msnyder@vmware.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00031.txt.bz2 That is very good for me. Thanks. Hui On Fri, May 1, 2009 at 17:26, Eli Zaretskii wrote: > May I suggest the following changes in some of the doc strings related > to this feature? =A0In addition to rewording, it also reformats the way > the strings are presented, so that it is easy to spot when we exceed > the width of the screen and need to break long lines. > > 2009-05-01 =A0Eli Zaretskii =A0 > > =A0 =A0 =A0 =A0* record.c (_initialize_record): Reformat and clarify doc = strings > =A0 =A0 =A0 =A0for stop-at-limit and insn-number-max. > > Index: gdb/record.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /cvs/src/src/gdb/record.c,v > retrieving revision 1.2 > diff -u -r1.2 record.c > --- gdb/record.c =A0 =A0 =A0 =A030 Apr 2009 02:58:37 -0000 =A0 =A0 =A01.2 > +++ gdb/record.c =A0 =A0 =A0 =A01 May 2009 09:24:01 -0000 > @@ -1259,28 +1259,21 @@ > > =A0 /* Record instructions number limit command. =A0*/ > =A0 add_setshow_boolean_cmd ("stop-at-limit", no_class, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &record_stop_at_lim= it, > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("Set whether reco= rd/replay stop when " > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "record/replay = buffer becomes full."), > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("Show whether rec= ord/replay stop when " > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "record/replay = buffer becomes full."), > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("Enable is defaul= t value.\n" > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "When enabled, = if the record/replay buffer " > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "becomes full,\= n" > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"ask user wh= at to do.\n" > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"When disabl= ed, if the record/replay buffer " > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 "becomes full,\= n" > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"delete it a= nd start new recording."), > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &record_stop_at_lim= it, _("\ > +Set whether record/replay stops when record/replay buffer becomes full."= ), _("\ > +Show whether record/replay stops when record/replay buffer becomes full.= "), _("\ > +Default is ON.\n\ > +When ON, if the record/replay buffer becomes full, ask user what to do.\= n\ > +When OFF, if the record/replay buffer becomes full,\n\ > +delete the oldest recorded instruction to make room for each new one."), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0NULL, NULL, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &set_record_cmdli= st, &show_record_cmdlist); > =A0 add_setshow_zinteger_cmd ("insn-number-max", no_class, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&record_insn_max_n= um, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0_("Set record/repl= ay buffer limit."), > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("Show record/repl= ay buffer limit."), > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("Set the maximum = number of instructions to be " > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"stored in t= he\n" > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"record/repl= ay buffer. =A0" > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0"Zero means = unlimited (default 200000)."), > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 _("Show record/repl= ay buffer limit."), _("\ > +Set the maximum number of instructions to be stored in the\n\ > +record/replay buffer. =A0Zero means unlimited. =A0Default is 200000."), > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0set_record_insn_ma= x_num, > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0NULL, &set_record_= cmdlist, &show_record_cmdlist); > =A0 add_cmd ("insn-number", class_obscure, show_record_insn_number, >