From: teawater <teawater@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Add _() to query
Date: Wed, 25 Feb 2009 07:18:00 -0000 [thread overview]
Message-ID: <daef60380902241815n7c38ec3eoa377fa5d0b099d2f@mail.gmail.com> (raw)
In-Reply-To: <ud4d7r7l7.fsf@gnu.org>
On Wed, Feb 25, 2009 at 02:52, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Tue, 24 Feb 2009 15:10:51 +0800
>> From: teawater <teawater@gmail.com>
>>
>> Hi Eli,
>>
>> I remember you told me that you want to add _() to all query.
>> I make a patch for it. Do you think it's OK?
>
> Yes, with the exception of a single comment below.
>
> (I don't have an opinion regarding the _() vs --keyword approach to
> marking translatable strings.)
>
>> - if (from_tty && (!query ("%s", "")))
>> + if (from_tty && (!query (_("%s"), "")))
>
> AFAIK, it is absolutely pointless to mark for translation strings that
> have no text, just formatted output conversion spec. That's because
> the only translation of such strings is the string itself.
>
Thanks Eli, I have removed this line and checked patch in.
Hui
prev parent reply other threads:[~2009-02-25 2:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 10:52 teawater
2009-02-24 14:33 ` Daniel Jacobowitz
2009-02-24 14:38 ` Jan Kratochvil
2009-02-24 14:57 ` Daniel Jacobowitz
2009-02-24 15:32 ` Jan Kratochvil
2009-02-24 19:46 ` Eli Zaretskii
2009-02-25 7:18 ` teawater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daef60380902241815n7c38ec3eoa377fa5d0b099d2f@mail.gmail.com \
--to=teawater@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox