From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9896 invoked by alias); 25 Feb 2009 02:15:50 -0000 Received: (qmail 9886 invoked by uid 22791); 25 Feb 2009 02:15:49 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Feb 2009 02:15:44 +0000 Received: by ti-out-0910.google.com with SMTP id y8so2501740tia.12 for ; Tue, 24 Feb 2009 18:15:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.110.50.19 with SMTP id x19mr143151tix.21.1235528141369; Tue, 24 Feb 2009 18:15:41 -0800 (PST) In-Reply-To: References: Date: Wed, 25 Feb 2009 07:18:00 -0000 Message-ID: Subject: Re: [RFA] Add _() to query From: teawater To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00478.txt.bz2 On Wed, Feb 25, 2009 at 02:52, Eli Zaretskii wrote: >> Date: Tue, 24 Feb 2009 15:10:51 +0800 >> From: teawater >> >> Hi Eli, >> >> I remember you told me that you want to add _() to all query. >> I make a patch for it. Do you think it's OK? > > Yes, with the exception of a single comment below. > > (I don't have an opinion regarding the _() vs --keyword approach to > marking translatable strings.) > >> - =A0if (from_tty && (!query ("%s", ""))) >> + =A0if (from_tty && (!query (_("%s"), ""))) > > AFAIK, it is absolutely pointless to mark for translation strings that > have no text, just formatted output conversion spec. =A0That's because > the only translation of such strings is the string itself. > Thanks Eli, I have removed this line and checked patch in. Hui