Re: [RFA] Resubmit process record and replay, 7/10

[teawater <teawater@gmail.com>]

Thanks Pedro,


Agree with your idea in record_wait part.  Actually, I plan to do it
after P record check-in in the before.
Now, I will do it  at once. :)

On the other hand, could you let me keep the code in linux-nat.c.
Because I think it can make linux-nat record speed up.

What about write a special function to check the breakpoint? Then both
linux-nat and record_wait can call it.


Hui

On Thu, Nov 20, 2008 at 10:50, Pedro Alves <alves.ped@gmail.com> wrote:
> On Thursday 20 November 2008 02:40:46, Pedro Alves wrote:
>
>> Can you please try moving all this blob...
>
> [...]
>
>> ... to the record target?  It seems to be interested in getting
>> *all* events, instead of letting linux_nat_wait filter some.
>
> Sorry, reading back, I don't think I explained myself that well.  I meant
> something like:
>
> ptid_t
> record_wait (ptid_t ptid, target_waitstatus *status)
> {
>  while (1)
>  {
>     eptid = beneath->to_wait (ptid, &status);
>
>     if (status.kind == TARGET_WAITKIND_TRAP)
>      {
>         if breakpoint_here (pc - pc_adjustement)
>           {
>             got breakpoint;
>             break;
>           }
>         record_message ();
>         beneath->resume (step);
>      }
>      else
>        break probably.
>  }
>
>  if (got breakpoint)
>    adjust_pc;
>  return eptid;
> }
>
> --
> Pedro Alves
>