Re: [RFA] Process record and replay, 9/10

[teawater <teawater@gmail.com>]

Thanks Eli,

On Fri, Nov 7, 2008 at 22:52, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Thu, 6 Nov 2008 15:51:51 +0800
>> From: teawater <teawater@gmail.com>
>>
>> +  /* Record the return of system call. */
>
> Two spaces after the period that ends a sentence, please.

OK. I will fix all of them in the patches.


>
>> +/* These macros are the size of the type that will be use in system call. The values of
>                                                 ^^^^^^^^^^^
> "will be used" or "will be in use".

I will change it.


>
>> +   these macros are gotten from Linux Kernel source. */
>> +#define I386_RECORD_SIZE__old_kernel_stat    32
>> +#define I386_RECORD_SIZE_tms                 16
>> +#define I386_RECORD_SIZE_loff_t                      8
>> +#define I386_RECORD_SIZE_flock                       16
>> +#define I386_RECORD_SIZE_oldold_utsname              45
>> +#define I386_RECORD_SIZE_ustat                       20
>
> Shouldn't this kind of database be in the XML files just posted in the
> "catch syscall" thread?
>
This is the size of variables in the Linux Kernel. I set it special
because sometime this variables for each arches are not same.