From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59754-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10092 invoked by alias); 8 Nov 2008 05:04:53 -0000
Received: (qmail 10029 invoked by uid 22791); 8 Nov 2008 05:04:52 -0000
X-Spam-Check-By: sourceware.org
Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Nov 2008 05:04:16 +0000
Received: by ti-out-0910.google.com with SMTP id d10so855234tib.12         for <gdb-patches@sourceware.org>; Fri, 07 Nov 2008 21:04:13 -0800 (PST)
Received: by 10.110.57.6 with SMTP id f6mr4641187tia.55.1226120653115;         Fri, 07 Nov 2008 21:04:13 -0800 (PST)
Received: by 10.110.103.3 with HTTP; Fri, 7 Nov 2008 21:04:13 -0800 (PST)
Message-ID: <daef60380811072104j4e95269cmbf419cf575a90e66@mail.gmail.com>
Date: Sat, 08 Nov 2008 05:04:00 -0000
From: teawater <teawater@gmail.com>
To: "Eli Zaretskii" <eliz@gnu.org>
Subject: Re: [RFA] Process record and replay, 9/10
Cc: gdb-patches@sourceware.org
In-Reply-To: <ur65nsi5h.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <daef60380811052351p2ce19d86o678efa9b044780d1@mail.gmail.com> 	 <ur65nsi5h.fsf@gnu.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00145.txt.bz2

Thanks Eli,

On Fri, Nov 7, 2008 at 22:52, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Thu, 6 Nov 2008 15:51:51 +0800
>> From: teawater <teawater@gmail.com>
>>
>> +  /* Record the return of system call. */
>
> Two spaces after the period that ends a sentence, please.

OK. I will fix all of them in the patches.


>
>> +/* These macros are the size of the type that will be use in system call. The values of
>                                                 ^^^^^^^^^^^
> "will be used" or "will be in use".

I will change it.


>
>> +   these macros are gotten from Linux Kernel source. */
>> +#define I386_RECORD_SIZE__old_kernel_stat    32
>> +#define I386_RECORD_SIZE_tms                 16
>> +#define I386_RECORD_SIZE_loff_t                      8
>> +#define I386_RECORD_SIZE_flock                       16
>> +#define I386_RECORD_SIZE_oldold_utsname              45
>> +#define I386_RECORD_SIZE_ustat                       20
>
> Shouldn't this kind of database be in the XML files just posted in the
> "catch syscall" thread?
>
This is the size of variables in the Linux Kernel. I set it special
because sometime this variables for each arches are not same.