Re: [RFA] Process record and replay, 10/10

[teawater <teawater@gmail.com>]

Thanks Eli,

On Fri, Nov 7, 2008 at 22:48, Eli Zaretskii <eliz@gnu.org> wrote:
>> Date: Thu, 6 Nov 2008 15:52:30 +0800
>> From: teawater <teawater@gmail.com>
>>
>> This patch add document for process record and replay.
>>
>> 2008-11-06  Hui Zhu  <teawater@gmail.com>
>>
>>       * gdb.texinfo: Add documentation for process record and replay.
>
> Thanks.  I have a couple of comments.
>
>> +@chapter Recording programs running message and replay it
>
> I don't understand this phrase.  What did you want to say? what does
> the word "message" have to do with this feature?


What about "Recording inferior execute log and replay it"?



>
>> +@kindex target record
>> +@kindex record
>> +@kindex rec
>> +@item target record
>> +This a standard command to start process record and replay target.
>> +Process record and replay target can only debug a process that already
>> +running.  Therefore you need to first start the process @code{run},
>> +and then start the recording @code{record}.
>
> Is the command "target record" or just "record"? or is the latter an
> alias of the former?  We need to explain all this in the manual,
> because the @item says "target record", while in the last sentence
> above you say that the command is "record"

"target record" is the real command.
"record" is a command call "target record". I want it to be the alias
of "target record"
"rec" is a alias of "record".

What about change "@code{record}" to "@code{target record}"?

>
> Other than that, this part of the patch is okay.
>
> By the way, I think we need a NEWS entry for this feature.
>

What about add this:

* Process record and replay

  Record inferior execute log and replay it.