From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5459 invoked by alias); 8 Nov 2008 04:40:26 -0000 Received: (qmail 5412 invoked by uid 22791); 8 Nov 2008 04:40:25 -0000 X-Spam-Check-By: sourceware.org Received: from ti-out-0910.google.com (HELO ti-out-0910.google.com) (209.85.142.185) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 08 Nov 2008 04:39:48 +0000 Received: by ti-out-0910.google.com with SMTP id d10so850585tib.12 for ; Fri, 07 Nov 2008 20:39:44 -0800 (PST) Received: by 10.110.47.9 with SMTP id u9mr106480tiu.15.1226119184889; Fri, 07 Nov 2008 20:39:44 -0800 (PST) Received: by 10.110.103.3 with HTTP; Fri, 7 Nov 2008 20:39:44 -0800 (PST) Message-ID: Date: Sat, 08 Nov 2008 04:40:00 -0000 From: teawater To: "Eli Zaretskii" Subject: Re: [RFA] Process record and replay, 10/10 Cc: gdb-patches@sourceware.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00144.txt.bz2 Thanks Eli, On Fri, Nov 7, 2008 at 22:48, Eli Zaretskii wrote: >> Date: Thu, 6 Nov 2008 15:52:30 +0800 >> From: teawater >> >> This patch add document for process record and replay. >> >> 2008-11-06 Hui Zhu >> >> * gdb.texinfo: Add documentation for process record and replay. > > Thanks. I have a couple of comments. > >> +@chapter Recording programs running message and replay it > > I don't understand this phrase. What did you want to say? what does > the word "message" have to do with this feature? What about "Recording inferior execute log and replay it"? > >> +@kindex target record >> +@kindex record >> +@kindex rec >> +@item target record >> +This a standard command to start process record and replay target. >> +Process record and replay target can only debug a process that already >> +running. Therefore you need to first start the process @code{run}, >> +and then start the recording @code{record}. > > Is the command "target record" or just "record"? or is the latter an > alias of the former? We need to explain all this in the manual, > because the @item says "target record", while in the last sentence > above you say that the command is "record" "target record" is the real command. "record" is a command call "target record". I want it to be the alias of "target record" "rec" is a alias of "record". What about change "@code{record}" to "@code{target record}"? > > Other than that, this part of the patch is okay. > > By the way, I think we need a NEWS entry for this feature. > What about add this: * Process record and replay Record inferior execute log and replay it.