[patch]: Fix memory leak of symtab.c

[patch]: Fix memory leak of symtab.c

[teawater]

symtab.c has a memory leek in function expand_line_sal. struct block
**blocks and int *filter are xmalloc at line 4459 and 4460. There are
returns at the end of this function without calling xfree. And these
variables is just used in this function. So I change them to "alloca".
This patch is for the GDB cvs version.

2008-06-21  Hui Zhu  <teawater@gmail.com>
      * symtab.c (expand_line_sal): Fix a memory leak.

--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -4456,8 +4456,8 @@ expand_line_sal (struct symtab_and_line
      blocks -- for each PC found above we see if there are other PCs
      that are in the same block.  If yes, the other PCs are filtered out.  */

-  filter = xmalloc (ret.nelts * sizeof (int));
-  blocks = xmalloc (ret.nelts * sizeof (struct block *));
+  filter = alloca (ret.nelts * sizeof (int));
+  blocks = alloca (ret.nelts * sizeof (struct block *));
   for (i = 0; i < ret.nelts; ++i)
     {
       filter[i] = 1;

Re: [patch]: Fix memory leak of symtab.c

[Joel Brobecker]

> 2008-06-21  Hui Zhu  <teawater@gmail.com>
>       * symtab.c (expand_line_sal): Fix a memory leak.

Yes, this is OK. (just make sure to have an empty line between the
ChangeLog header and the actual contents)

Thank you!

-- 
Joel

Re: [patch]: Fix memory leak of symtab.c

[teawater]

OK. Thanks Joel.

2008-06-21  Hui Zhu  <teawater@gmail.com>

     * symtab.c (expand_line_sal): Fix a memory leak.

--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -4456,8 +4456,8 @@ expand_line_sal (struct symtab_and_line
     blocks -- for each PC found above we see if there are other PCs
     that are in the same block.  If yes, the other PCs are filtered out.  */

-  filter = xmalloc (ret.nelts * sizeof (int));
-  blocks = xmalloc (ret.nelts * sizeof (struct block *));
+  filter = alloca (ret.nelts * sizeof (int));
+  blocks = alloca (ret.nelts * sizeof (struct block *));
  for (i = 0; i < ret.nelts; ++i)
    {
      filter[i] = 1;

On Thu, Jul 10, 2008 at 01:15, Joel Brobecker <brobecker@adacore.com> wrote:
>> 2008-06-21  Hui Zhu  <teawater@gmail.com>
>>       * symtab.c (expand_line_sal): Fix a memory leak.
>
> Yes, this is OK. (just make sure to have an empty line between the
> ChangeLog header and the actual contents)
>
> Thank you!
>
> --
> Joel
>

Re: [patch]: Fix memory leak of symtab.c

[Joel Brobecker]

> 2008-06-21  Hui Zhu  <teawater@gmail.com>
> 
>      * symtab.c (expand_line_sal): Fix a memory leak.

Michael told me that you don't have write access.  So I checked you
patch in for you.  Are there other patches that we approved and didn't
get checked in?

As I told Michael, you qualify for write-after-approval priviledges
(this would allow you to commit the changes yourself after they are
approved).  Let me know if you're interested.

-- 
Joel

Re: [patch]: Fix memory leak of symtab.c

[teawater]

Hi Joel,

> Michael told me that you don't have write access.  So I checked you
> patch in for you.  Are there other patches that we approved and didn't
> get checked in?

I don't have other patches need to check-in. Thanks for your help.

>
> As I told Michael, you qualify for write-after-approval priviledges
> (this would allow you to commit the changes yourself after they are
> approved).  Let me know if you're interested.

Great! It's my pleasure. Thanks you very much. :)

Hui