From: Simon Marchi <simon.marchi@polymtl.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/4] Add DWARF index cache
Date: Mon, 30 Jul 2018 17:05:00 -0000 [thread overview]
Message-ID: <daa1cc09bd600e108010e2b84d92d7cb@polymtl.ca> (raw)
In-Reply-To: <83in4wpvh3.fsf@gnu.org>
On 2018-07-30 11:57, Eli Zaretskii wrote:
>> Date: Mon, 30 Jul 2018 11:33:20 -0400
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org
>>
>> > mkdir accepts only one argument, not 2.
>>
>> It builds fine with x86_64-w64-mingw32-g++ on Linux here. It looks
>> like
>> gnulib offers a compatibility fix, so I guess it's ok:
>>
>> https://www.gnu.org/software/gnulib/manual/html_node/mkdir.html
>>
>> Did you see an actual failure?
>
> No, I looked in the source tree and didn't see the Gnulib's mkdir
> imported. But maybe it was added meanwhile.
Well, it looks like gnulib's sys/stat.h offers some basic compatibility
fix (to get the right include and signature) when building on mingw and
MSVC, even without importing the mkdir module. But it would probably be
better to explicitly import the mkdir module, I'll do this in the next
version.
Simon
prev parent reply other threads:[~2018-07-30 17:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 22:47 [PATCH v2 0/4] Add a " Simon Marchi
2018-07-25 22:47 ` [PATCH v2 4/4] Add doc and news for " Simon Marchi
2018-07-27 8:50 ` Eli Zaretskii
2018-07-30 19:04 ` Simon Marchi
2018-07-30 19:23 ` Eli Zaretskii
2018-07-25 22:47 ` [PATCH v2 2/4] Introduce mmap_file function Simon Marchi
2018-07-25 22:48 ` [PATCH v2 1/4] Make index reading functions more modular Simon Marchi
2018-07-25 22:48 ` [PATCH v2 3/4] Add DWARF index cache Simon Marchi
2018-07-27 9:06 ` Eli Zaretskii
2018-07-27 14:01 ` Simon Marchi
2018-07-27 21:25 ` Eli Zaretskii
2018-07-30 15:33 ` Simon Marchi
2018-07-30 15:45 ` Simon Marchi
2018-07-30 15:57 ` Eli Zaretskii
2018-07-30 17:05 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daa1cc09bd600e108010e2b84d92d7cb@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox