From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34158 invoked by alias); 30 Jul 2018 17:05:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34148 invoked by uid 89); 30 Jul 2018 17:05:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Jul 2018 17:05:01 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w6UH4s0v002655 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 30 Jul 2018 13:04:59 -0400 Received: by simark.ca (Postfix, from userid 112) id CC0381EF29; Mon, 30 Jul 2018 13:04:54 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id F2CD41E08D; Mon, 30 Jul 2018 13:04:50 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 30 Jul 2018 17:05:00 -0000 From: Simon Marchi To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 3/4] Add DWARF index cache In-Reply-To: <83in4wpvh3.fsf@gnu.org> References: <1532558824-829-1-git-send-email-simon.marchi@ericsson.com> <1532558824-829-4-git-send-email-simon.marchi@ericsson.com> <83o9etrqsj.fsf@gnu.org> <83sh44qslw.fsf@gnu.org> <329544a9d729cbf659887269a4ba4a06@polymtl.ca> <83in4wpvh3.fsf@gnu.org> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00775.txt.bz2 On 2018-07-30 11:57, Eli Zaretskii wrote: >> Date: Mon, 30 Jul 2018 11:33:20 -0400 >> From: Simon Marchi >> Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org >> >> > mkdir accepts only one argument, not 2. >> >> It builds fine with x86_64-w64-mingw32-g++ on Linux here. It looks >> like >> gnulib offers a compatibility fix, so I guess it's ok: >> >> https://www.gnu.org/software/gnulib/manual/html_node/mkdir.html >> >> Did you see an actual failure? > > No, I looked in the source tree and didn't see the Gnulib's mkdir > imported. But maybe it was added meanwhile. Well, it looks like gnulib's sys/stat.h offers some basic compatibility fix (to get the right include and signature) when building on mingw and MSVC, even without importing the mkdir module. But it would probably be better to explicitly import the mkdir module, I'll do this in the next version. Simon