From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 06/12] Pass breakpoint type in set_breakpoint_at
Date: Mon, 13 Jun 2016 15:07:00 -0000 [thread overview]
Message-ID: <da2f0d0a-3e55-b56c-3d33-0d2efc6b64d6@redhat.com> (raw)
In-Reply-To: <1464859846-15619-7-git-send-email-yao.qi@linaro.org>
On 06/02/2016 10:30 AM, Yao Qi wrote:
> V2: rename set_breakpoint_at_1 to set_breakpoint_type_at
>
> Nowadays, set_breakpoint_at creates breakpoint of type
> other_breakpoint, but we also use set_breakpoint_at
> in set_reinsert_breakpoint to create breakpoint, so that
> we have to overwrite the breakpoint type like this,
>
> bp = set_breakpoint_at (stop_at, NULL);
> bp->type = reinsert_breakpoint;
>
> which looks not very good. This patch changes set_breakpoint_at
> to receive breakpoint type. Since set_breakpoint_at is
> used in many places, I rename it to set_breakpoint_type_at, and wrap
> it with set_breakpoint_at, and pass other_breakpoint. In this way,
> we can call set_breakpoint_type_at with reinsert_breakpoint in
> set_reinsert_breakpoint too, and code looks cleaner.
>
> gdb/gdbserver:
>
> 2016-05-31 Yao Qi <yao.qi@linaro.org>
>
> * mem-break.c (set_breakpoint_at): Rename it to ...
> (set_breakpoint_type_at): ... it.
> (set_breakpoint_at): Call set_breakpoint_type_at.
> (set_reinsert_breakpoint): Call set_breakpoint_type_at.
> * mem-break.h (set_breakpoint_at): Update comments.
OK.
Thanks,
Pedro Alves
prev parent reply other threads:[~2016-06-13 15:07 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:31 [PATCH 00/12 V2] Use reinsert breakpoint for vCont;s Yao Qi
2016-06-02 9:31 ` [PATCH 05/12] Handle reinsert breakpoints for vforked child Yao Qi
2016-06-13 15:07 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 10/12] Switch current_thread to lwp's thread in install_software_single_step_breakpoints Yao Qi
2016-06-13 15:26 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 11/12] Use reinsert_breakpoint for vCont;s Yao Qi
2016-06-13 15:55 ` Pedro Alves
2016-06-14 13:14 ` Yao Qi
2016-06-14 15:48 ` Pedro Alves
2016-06-15 16:41 ` Yao Qi
2016-06-17 15:10 ` Pedro Alves
2016-06-20 18:09 ` Antoine Tremblay
2016-06-02 9:31 ` [PATCH 04/12] Delete reinsert breakpoints from forked child Yao Qi
2016-06-13 15:02 ` Pedro Alves
2016-06-13 16:53 ` Yao Qi
2016-06-13 17:29 ` Pedro Alves
2016-06-14 11:17 ` Yao Qi
2016-06-14 11:40 ` Pedro Alves
2016-06-17 9:53 ` Yao Qi
2016-06-02 9:31 ` [PATCH 02/12] More assert checks on reinsert breakpoint Yao Qi
2016-06-13 14:25 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 12/12] Support vCont s and S actions with software single step Yao Qi
2016-06-13 15:56 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 07/12] Create sub classes of 'struct breakpoint' Yao Qi
2016-06-13 15:09 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 09/12] Make reinsert_breakpoint thread specific Yao Qi
[not found] ` <71a5322e-41e3-9e23-df73-e14b14c1d656@redhat.com>
2016-06-14 12:52 ` Yao Qi
2016-06-14 12:57 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 08/12] Refactor clone_all_breakpoints Yao Qi
2016-06-13 15:14 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 01/12] Switch to current thread in finish_step_over Yao Qi
2016-06-13 14:25 ` Pedro Alves
2016-06-02 9:31 ` [PATCH 03/12] Step over exit with reinsert breakpoints Yao Qi
2016-06-13 14:37 ` Pedro Alves
2016-06-13 14:52 ` Yao Qi
2016-06-13 15:01 ` Pedro Alves
2016-06-17 9:50 ` Yao Qi
2016-06-02 9:31 ` [PATCH 06/12] Pass breakpoint type in set_breakpoint_at Yao Qi
2016-06-13 15:07 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da2f0d0a-3e55-b56c-3d33-0d2efc6b64d6@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox