From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56326 invoked by alias); 13 Jun 2016 15:07:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56303 invoked by uid 89); 13 Jun 2016 15:07:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=overwrite, cleaner X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 15:07:46 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 90F9F83F46; Mon, 13 Jun 2016 15:07:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DF7ihU008099; Mon, 13 Jun 2016 11:07:44 -0400 Subject: Re: [PATCH 06/12] Pass breakpoint type in set_breakpoint_at To: Yao Qi , gdb-patches@sourceware.org References: <1464859846-15619-1-git-send-email-yao.qi@linaro.org> <1464859846-15619-7-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: Date: Mon, 13 Jun 2016 15:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464859846-15619-7-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00236.txt.bz2 On 06/02/2016 10:30 AM, Yao Qi wrote: > V2: rename set_breakpoint_at_1 to set_breakpoint_type_at > > Nowadays, set_breakpoint_at creates breakpoint of type > other_breakpoint, but we also use set_breakpoint_at > in set_reinsert_breakpoint to create breakpoint, so that > we have to overwrite the breakpoint type like this, > > bp = set_breakpoint_at (stop_at, NULL); > bp->type = reinsert_breakpoint; > > which looks not very good. This patch changes set_breakpoint_at > to receive breakpoint type. Since set_breakpoint_at is > used in many places, I rename it to set_breakpoint_type_at, and wrap > it with set_breakpoint_at, and pass other_breakpoint. In this way, > we can call set_breakpoint_type_at with reinsert_breakpoint in > set_reinsert_breakpoint too, and code looks cleaner. > > gdb/gdbserver: > > 2016-05-31 Yao Qi > > * mem-break.c (set_breakpoint_at): Rename it to ... > (set_breakpoint_type_at): ... it. > (set_breakpoint_at): Call set_breakpoint_type_at. > (set_reinsert_breakpoint): Call set_breakpoint_type_at. > * mem-break.h (set_breakpoint_at): Update comments. OK. Thanks, Pedro Alves