From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/5] Fix and cleanups in jit.c
Date: Tue, 17 Dec 2019 19:10:00 -0000 [thread overview]
Message-ID: <d9b426a2-d690-b989-a328-6e2769980ee4@redhat.com> (raw)
In-Reply-To: <154891dd-26d5-5844-09c4-00643b2f37b5@polymtl.ca>
On 12/16/19 11:19 PM, Simon Marchi wrote:
> On 2019-12-16 2:27 p.m., Pedro Alves wrote:
>> On 12/16/19 3:39 AM, Simon Marchi wrote:
>>> This is a follow-up to:
>>>
>>> https://sourceware.org/ml/gdb-patches/2019-12/msg00568.html
>>>
>>> Again, the first patch is a fix and the rest is some c++ification.
>>>
>>> I think I fixed all review comments from v1, the biggest change being
>>> the use of std::forward_list instead of std::vector.
>>
>> Thanks, LGTM.
>>
>> Pedro Alves
>
> Thanks, I pushed the series. Do you think I should push patch 1/5
> to the stable branch? It's not a new bug introduced in the last cycle,
> it's been there forever, so I'm not sure what we usually do in these
> cases.
Sure, that's fine with me. Generally it's fine to backport bugfixes
that are supposedly safe, and not invasive, such as this one.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-12-17 19:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 3:39 Simon Marchi
2019-12-16 3:39 ` [PATCH v2 5/5] jit: make gdb_symtab::blocks an std::forward_list Simon Marchi
2019-12-16 3:39 ` [PATCH v2 2/5] jit: c++-ify gdb_symtab Simon Marchi
2019-12-16 3:39 ` [PATCH v2 3/5] jit: make gdb_object::symtabs an std::forward_list Simon Marchi
2019-12-16 3:39 ` [PATCH v2 1/5] Fix double-free when creating more than one block in JIT debug info reader Simon Marchi
2019-12-16 3:57 ` [PATCH v2 4/5] jit: c++-ify gdb_block Simon Marchi
2019-12-16 19:27 ` [PATCH v2 0/5] Fix and cleanups in jit.c Pedro Alves
2019-12-16 23:19 ` Simon Marchi
2019-12-17 19:10 ` Pedro Alves [this message]
2019-12-17 19:32 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9b426a2-d690-b989-a328-6e2769980ee4@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox