From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116350 invoked by alias); 17 Dec 2019 19:10:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116341 invoked by uid 89); 17 Dec 2019 19:10:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (205.139.110.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Dec 2019 19:10:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576609826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EH9I3VgcSAkEhtGBKM8TV8lgRGsAYYpBTbL4fNg1inY=; b=iJ2eyzsCql2Ajnk/k+ik2PML5XhmlU+CxbnhTb3fWLjxDI4XBsEL7aCzV861DQ6wpdp78c 1KupaMJ0Kn98KBb55Lkjo0VC+0DjS8LEShEBTKJ0qgKStKcEwueXQ5VznJoPkEpGMEy27F r27/mNcKku32ktBQWcf+eKHnT74QH48= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-274-vUhXVISOPMKcro2qP_OrcQ-1; Tue, 17 Dec 2019 14:10:24 -0500 Received: by mail-wr1-f72.google.com with SMTP id r2so249203wrp.7 for ; Tue, 17 Dec 2019 11:10:24 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id o15sm27053389wra.83.2019.12.17.11.10.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Dec 2019 11:10:22 -0800 (PST) Subject: Re: [PATCH v2 0/5] Fix and cleanups in jit.c To: Simon Marchi , gdb-patches@sourceware.org References: <20191216033917.2936248-1-simon.marchi@polymtl.ca> <9deeca6f-f280-c8bc-f09b-ba422a91f016@redhat.com> <154891dd-26d5-5844-09c4-00643b2f37b5@polymtl.ca> From: Pedro Alves Message-ID: Date: Tue, 17 Dec 2019 19:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <154891dd-26d5-5844-09c4-00643b2f37b5@polymtl.ca> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00750.txt.bz2 On 12/16/19 11:19 PM, Simon Marchi wrote: > On 2019-12-16 2:27 p.m., Pedro Alves wrote: >> On 12/16/19 3:39 AM, Simon Marchi wrote: >>> This is a follow-up to: >>> >>> https://sourceware.org/ml/gdb-patches/2019-12/msg00568.html >>> >>> Again, the first patch is a fix and the rest is some c++ification. >>> >>> I think I fixed all review comments from v1, the biggest change being >>> the use of std::forward_list instead of std::vector. >> >> Thanks, LGTM. >> >> Pedro Alves > > Thanks, I pushed the series. Do you think I should push patch 1/5 > to the stable branch? It's not a new bug introduced in the last cycle, > it's been there forever, so I'm not sure what we usually do in these > cases. Sure, that's fine with me. Generally it's fine to backport bugfixes that are supposedly safe, and not invasive, such as this one. Thanks, Pedro Alves