Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yousong Zhou <yszhou4tech@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix invalid sigprocmask call
Date: Fri, 24 Mar 2017 12:58:00 -0000	[thread overview]
Message-ID: <d9012958-5f35-5c4a-7783-c362c1e1b1bc@redhat.com> (raw)
In-Reply-To: <CAECwjAh3vsSDZekRXAomB8iWDy9ULOYpJcA866sWUyAnNFGPnA@mail.gmail.com>

On 03/24/2017 12:39 PM, Yousong Zhou wrote:

> The following test case will also say for itself.
> 
>         https://github.com/juj/posixtestsuite/blob/master/conformance/interfaces/pthread_sigmask/16-1.c

It does not.  The pthread_sigmask call there does NOT pass a NULL
as "set mask" argument:

	if (pthread_sigmask(r, &actl, NULL) != EINVAL) {
		perror("pthread_sigmask() did not fail even though invalid how parameter was passed to it.\n");
		pthread_exit((void*)-1);
	}

That case _should_ fail, of course.

Please just fix musl.

Thanks,
Pedro Alves


  reply	other threads:[~2017-03-24 12:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1490324519-11228-1-git-send-email-yszhou4tech@gmail.com>
2017-03-24 10:47 ` Pedro Alves
2017-03-24 12:24   ` Yousong Zhou
2017-03-24 12:39     ` Yousong Zhou
2017-03-24 12:58       ` Pedro Alves [this message]
2017-03-24 12:55     ` Pedro Alves
2017-03-24 13:05       ` Yousong Zhou
2017-03-24 13:37         ` Pedro Alves
2017-03-25  0:36           ` Yousong Zhou
2017-03-24 15:35         ` [musl] " Rich Felker
2017-03-24 15:52           ` Pedro Alves
2017-03-24 16:41             ` Rich Felker
2017-03-24 17:34           ` Andreas Schwab
2017-03-24 18:15             ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9012958-5f35-5c4a-7783-c362c1e1b1bc@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yszhou4tech@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox