From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25900 invoked by alias); 24 Mar 2017 12:58:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24931 invoked by uid 89); 24 Mar 2017 12:58:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=Hx-languages-length:584 X-HELO: mail-wm0-f45.google.com Received: from mail-wm0-f45.google.com (HELO mail-wm0-f45.google.com) (74.125.82.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Mar 2017 12:58:25 +0000 Received: by mail-wm0-f45.google.com with SMTP id u132so12404192wmg.0 for ; Fri, 24 Mar 2017 05:58:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=k9iCJdJSmX+wiQvaCzU54Cshit9VpUJjA4g58PmpTSU=; b=e42fE2J4uV0zH7aUWhNnQpsy4ji9QTiMVq+kAuAsWHaiyFS4/ZxcLwHNTCTlXeYO5C hsagkN2B4hJDIzSLyXOADR+cpSItYUMp7gIFX8I+5yuJUIcPOu1AEgQqHHL51v74IGO5 YUF4KTLRIC4iUBX2Iy02L4t15r02YA7Hh9Q0yS6tIe/U0tqJENyigcautzxiZN0FKfwp b4uXjbTBcFZQrwR2Nd/mrxvpM2TMp32uJmzcA+FqUJ0rtLV0KaKqUYvikUTZy3Qf8wcq XUIBgSoe9GZsjPQdK/q57dVqhYbpIbIgyoxVwqxuRsEBP4cAmVixFpqUXTI4byHxvzBD FHFw== X-Gm-Message-State: AFeK/H0wi6NUjxI6nUW14aaJ+JlI5qKE/Vyq5HMxxBIq6lB+Rocxkf1hib/Qia8Ylc0wk2HU X-Received: by 10.28.74.194 with SMTP id n63mr3116942wmi.15.1490360304116; Fri, 24 Mar 2017 05:58:24 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id v3sm2799113wrb.39.2017.03.24.05.58.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2017 05:58:23 -0700 (PDT) Subject: Re: [PATCH] Fix invalid sigprocmask call To: Yousong Zhou References: <1490324519-11228-1-git-send-email-yszhou4tech@gmail.com> <2b0bab84-e36e-e109-5444-dc84369dddce@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 24 Mar 2017 12:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00437.txt.bz2 On 03/24/2017 12:39 PM, Yousong Zhou wrote: > The following test case will also say for itself. > > https://github.com/juj/posixtestsuite/blob/master/conformance/interfaces/pthread_sigmask/16-1.c It does not. The pthread_sigmask call there does NOT pass a NULL as "set mask" argument: if (pthread_sigmask(r, &actl, NULL) != EINVAL) { perror("pthread_sigmask() did not fail even though invalid how parameter was passed to it.\n"); pthread_exit((void*)-1); } That case _should_ fail, of course. Please just fix musl. Thanks, Pedro Alves