* [PATCH] gdb.rocm/watchpoint-basic: add gfx1103 to XFAILs
@ 2026-08-07 16:28 Shahab Vahedi
2026-08-07 17:36 ` Simon Marchi
0 siblings, 1 reply; 4+ messages in thread
From: Shahab Vahedi @ 2026-08-07 16:28 UTC (permalink / raw)
To: gdb-patches; +Cc: Shahab Vahedi, Simon Marchi, Shahab Vahedi
Again, a confirmed KFD issue. By confirmed, I mean that if a dummy
dispatch is done first, then everything goes OK.
__global__ void dummy () {}
int main (...)
{
...
dummy<<<1, 1>>> ();
/* Break after malloc. */
kernel<<<1, 1>>> (global_ptr1, global_ptr2);
...
}
---
gdb/testsuite/gdb.rocm/watchpoint-basic.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.rocm/watchpoint-basic.exp b/gdb/testsuite/gdb.rocm/watchpoint-basic.exp
index bc30726515e..558a1f8472c 100644
--- a/gdb/testsuite/gdb.rocm/watchpoint-basic.exp
+++ b/gdb/testsuite/gdb.rocm/watchpoint-basic.exp
@@ -96,7 +96,7 @@ proc_with_prefix test_host_watchpoint_after_runtime_load {} {
# end and exit prematurely.
gdb_caching_proc target_has_xfail {} {
- set xfail_arches {gfx1201}
+ set xfail_arches {gfx1103 gfx1201}
set targets [find_amdgpu_devices]
if {[llength $targets] == 0} {
--
2.55.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb.rocm/watchpoint-basic: add gfx1103 to XFAILs
2026-08-07 16:28 [PATCH] gdb.rocm/watchpoint-basic: add gfx1103 to XFAILs Shahab Vahedi
@ 2026-08-07 17:36 ` Simon Marchi
2026-08-07 20:58 ` Machado, Luis
0 siblings, 1 reply; 4+ messages in thread
From: Simon Marchi @ 2026-08-07 17:36 UTC (permalink / raw)
To: Shahab Vahedi, gdb-patches; +Cc: Shahab Vahedi, Simon Marchi
On 8/7/26 12:28 PM, Shahab Vahedi wrote:
> Again, a confirmed KFD issue. By confirmed, I mean that if a dummy
> dispatch is done first, then everything goes OK.
>
> __global__ void dummy () {}
>
> int main (...)
> {
> ...
> dummy<<<1, 1>>> ();
> /* Break after malloc. */
> kernel<<<1, 1>>> (global_ptr1, global_ptr2);
> ...
> }
If it's really the case that this arch exhibits the same problem, then
it's fine to continue with the existing pattern.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
As a subsequent comment, I wonder if, for these arches, instead of
xfail-ing, it would be more useful to dispatch that dummy commit and
then expect the watchpoint to work.
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb.rocm/watchpoint-basic: add gfx1103 to XFAILs
2026-08-07 17:36 ` Simon Marchi
@ 2026-08-07 20:58 ` Machado, Luis
2026-08-10 8:44 ` Vahedi, Shahab
0 siblings, 1 reply; 4+ messages in thread
From: Machado, Luis @ 2026-08-07 20:58 UTC (permalink / raw)
To: Simon Marchi, Vahedi, Shahab, gdb-patches
Cc: Shahab Vahedi, Simon Marchi, Six, Lancelot
> As a subsequent comment, I wonder if, for these arches, instead of
> xfail-ing, it would be more useful to dispatch that dummy commit and
> then expect the watchpoint to work.
I think that'd makes sense. And if we want to make sure we still expose the KFD issue, we could run a quick check first (but not FAIL) and proceed to use the workaround if needed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gdb.rocm/watchpoint-basic: add gfx1103 to XFAILs
2026-08-07 20:58 ` Machado, Luis
@ 2026-08-10 8:44 ` Vahedi, Shahab
0 siblings, 0 replies; 4+ messages in thread
From: Vahedi, Shahab @ 2026-08-10 8:44 UTC (permalink / raw)
To: Machado, Luis, Simon Marchi, gdb-patches
Cc: Shahab Vahedi, Simon Marchi, Six, Lancelot
On 7-Aug-2026 07:36PM, Simon Marchi wrote:
> As a subsequent comment, I wonder if, for these arches, instead of
> xfail-ing, it would be more useful to dispatch that dummy commit and
> then expect the watchpoint to work.
IMO, this would not trigger us if/when the KFD issue is resolved, so
the "list" won't go away. Having the "list" removed has the benefit
of treating any failure from that point onward as a new one.
On 7-Aug-2026 10:58PM, Machado, Luis wrote:
> I think that'd makes sense. And if we want to make sure we still expose
> the KFD issue, we could run a quick check first (but not FAIL) and
> proceed to use the workaround if needed.
What would be this quick-check (without failures)?
How would it cover new architectures?
Or is it going to "fallback" in case of "any" failure?
Yet again, how would it trigger us when the problem is resolved?
-Shahab
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-10 8:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-07 16:28 [PATCH] gdb.rocm/watchpoint-basic: add gfx1103 to XFAILs Shahab Vahedi
2026-08-07 17:36 ` Simon Marchi
2026-08-07 20:58 ` Machado, Luis
2026-08-10 8:44 ` Vahedi, Shahab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox