Re: [PATCH][gdb/testsuite] Emit unresolved for unknown proc

[Pedro Alves <pedro@palves.net>]

On 6/29/20 12:21 PM, Tom de Vries wrote:
> Hi,
> 
> Since commit 26783bce15 "[gdb/testsuite] Don't abort testrun for invalid
> command in test-case" we don't abort the testrun when encountering an invalid
> command.  However, since we don't report errors in the summary, there's a
> chance that the error goes unnoticed.
> 
> Make the invalid command error more visible by marking the test-case
> unresolved, such that we have f.i.:
> ...
> PASS: gdb.python/py-breakpoint.exp: test_bkpt_internal: Test watchpoint write
> UNRESOLVED: gdb.python/py-breakpoint.exp: test_bkpt_eval_funcs: \
>   testcase aborted due to invalid command name: gdb_py_test_multiple
> ERROR: tcl error sourcing py-breakpoint.exp.
> ERROR: invalid command name "gdb_py_test_multiple"
>     while executing
>   ...
>                 === gdb Summary ===
> 
> nr of expected passes            56
> nr of unresolved testcases       1
> ...
> 
> Tested on x86_64-linux.
> 
> Any comments?

LGTM.

Sounds like we'll end up with two UNRESOLVEDs for this when Jacob's
changes land in DejaGnu, right?  Do you plan on making this
dependent on dejagnu version, or leave the two UNRESOLVEDs anyway?

Thanks,
Pedro Alves