From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id 6A9023851C20 for ; Mon, 29 Jun 2020 11:54:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6A9023851C20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f44.google.com with SMTP id o2so15842679wmh.2 for ; Mon, 29 Jun 2020 04:54:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uR2d9iirS5ZEGvPYAhO7waLCFztG6FxAkw5uB5cKV/M=; b=Rx87NjmHt+PwJewKGTTLKUMgWJ3stc+UECl0xVcq70ogPn/jzEeO3ZlOXT738vMli6 o9sJ+z0LjxmR0P49EC4q4HWX0pa+fpRH4ptDrUZGKiOTFiu0VFj5W9JLv05Gsp+4cmQZ FcQNdky9RbkE2/A09Ic/VP//ov+V5XniEMUW7LxCDANPbz7gdu3Ou2QSYbOENB+B8gcG z38LkSjQnlgcrXztkee81EYNGx6k3xN+acRd8c3mhmzW9JS6HNH79Uk3U1eYjFIDEMY+ A19AmiPHY1NgM3w3uiDQC5DTxylyYcp4fYv6ukTjpsYLYKltJ3U371SB2q5GuGQZ0HxK JwZg== X-Gm-Message-State: AOAM533tup1+CM8fViHyhDfVwrgz0Y4LCgVR0g4n7A9niUffM69wnHlk lkGn+ZluDoGDFxjYXLmkJgKi7m7+Mb/KGA== X-Google-Smtp-Source: ABdhPJyvHS1h5IcqfKI72jvgVNagg6FVudGzaPjfDc/6pkk0ZJEeS8//gW9ADjrqJzVCfFqFn8suUQ== X-Received: by 2002:a1c:e18a:: with SMTP id y132mr16058901wmg.27.1593431679441; Mon, 29 Jun 2020 04:54:39 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r1sm39064867wrt.73.2020.06.29.04.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 04:54:38 -0700 (PDT) Subject: Re: [PATCH][gdb/testsuite] Emit unresolved for unknown proc To: Tom de Vries , gdb-patches@sourceware.org References: <20200629112105.GA5644@delia> From: Pedro Alves Message-ID: Date: Mon, 29 Jun 2020 12:54:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200629112105.GA5644@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 11:54:42 -0000 On 6/29/20 12:21 PM, Tom de Vries wrote: > Hi, > > Since commit 26783bce15 "[gdb/testsuite] Don't abort testrun for invalid > command in test-case" we don't abort the testrun when encountering an invalid > command. However, since we don't report errors in the summary, there's a > chance that the error goes unnoticed. > > Make the invalid command error more visible by marking the test-case > unresolved, such that we have f.i.: > ... > PASS: gdb.python/py-breakpoint.exp: test_bkpt_internal: Test watchpoint write > UNRESOLVED: gdb.python/py-breakpoint.exp: test_bkpt_eval_funcs: \ > testcase aborted due to invalid command name: gdb_py_test_multiple > ERROR: tcl error sourcing py-breakpoint.exp. > ERROR: invalid command name "gdb_py_test_multiple" > while executing > ... > === gdb Summary === > > nr of expected passes 56 > nr of unresolved testcases 1 > ... > > Tested on x86_64-linux. > > Any comments? LGTM. Sounds like we'll end up with two UNRESOLVEDs for this when Jacob's changes land in DejaGnu, right? Do you plan on making this dependent on dejagnu version, or leave the two UNRESOLVEDs anyway? Thanks, Pedro Alves