From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: Christian Biesinger <cbiesinger@google.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Add -Wstrict-null-sentinel to gdbsupport/warning.m4
Date: Tue, 11 Feb 2020 16:11:00 -0000 [thread overview]
Message-ID: <d5351fd6-6fcc-1ee6-9650-3cf200926988@simark.ca> (raw)
In-Reply-To: <87a75pdvfj.fsf@tromey.com>
On 2020-02-11 9:56 a.m., Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> On 2020-02-10 11:42 a.m., Christian Biesinger wrote:
>>> Any thoughts on instead dong:
>>> +-Wstrict-null-sentinel \
>>> +"
>>>
>>> so that future changes don't need to change the last line? Helps with blame too.
>
> Simon> Sure, I I'll do that. I like when we use a comma after the last enumerator in enums
> Simon> too, for the same reason.
>
> Me too.
>
> Thanks for doing this. I should have more mail this morning before
> writing this same patch :-)
>
> This looks good, please check it all in.
>
> Tom
>
Thanks, I pushed the series.
Simon
next prev parent reply other threads:[~2020-02-11 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 16:40 [PATCH 1/3] gdbsupport: use AM_GDB_WARNINGS Simon Marchi
2020-02-10 16:40 ` [PATCH 3/3] Add -Wstrict-null-sentinel to gdbsupport/warning.m4 Simon Marchi
2020-02-10 16:42 ` Christian Biesinger via gdb-patches
2020-02-10 16:46 ` Simon Marchi
2020-02-11 14:57 ` Tom Tromey
2020-02-11 16:11 ` Simon Marchi [this message]
2020-02-10 16:40 ` [PATCH 2/3] Move gdb/warning.m4 to gdbsupport Simon Marchi
2020-02-11 14:55 ` Tom Tromey
2020-02-11 14:55 ` [PATCH 1/3] gdbsupport: use AM_GDB_WARNINGS Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5351fd6-6fcc-1ee6-9650-3cf200926988@simark.ca \
--to=simark@simark.ca \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox