From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110958 invoked by alias); 11 Feb 2020 16:11:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110942 invoked by uid 89); 11 Feb 2020 16:11:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=UD:a.m, a.m X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Feb 2020 16:11:41 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 05FFE1E05A; Tue, 11 Feb 2020 11:11:38 -0500 (EST) Subject: Re: [PATCH 3/3] Add -Wstrict-null-sentinel to gdbsupport/warning.m4 To: Tom Tromey , Simon Marchi Cc: Christian Biesinger , gdb-patches References: <20200210164024.32445-1-simon.marchi@efficios.com> <20200210164024.32445-3-simon.marchi@efficios.com> <87a75pdvfj.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Tue, 11 Feb 2020 16:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87a75pdvfj.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00399.txt.bz2 On 2020-02-11 9:56 a.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> On 2020-02-10 11:42 a.m., Christian Biesinger wrote: >>> Any thoughts on instead dong: >>> +-Wstrict-null-sentinel \ >>> +" >>> >>> so that future changes don't need to change the last line? Helps with blame too. > > Simon> Sure, I I'll do that. I like when we use a comma after the last enumerator in enums > Simon> too, for the same reason. > > Me too. > > Thanks for doing this. I should have more mail this morning before > writing this same patch :-) > > This looks good, please check it all in. > > Tom > Thanks, I pushed the series. Simon