From: Simon Marchi <simark@simark.ca>
To: "Jose E. Marchesi" <jose.marchesi@oracle.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH V5 1/3] gdb: support for eBPF
Date: Sat, 1 Aug 2020 19:25:25 -0400 [thread overview]
Message-ID: <d3f6b4b0-e1cb-9d6b-9c55-2e37d78d3cb3@simark.ca> (raw)
In-Reply-To: <20200713122458.21339-2-jose.marchesi@oracle.com>
On 2020-07-13 8:24 a.m., Jose E. Marchesi via Gdb-patches wrote:
> +/* Implement the breakpoint_kind_from_pc gdbarch method. */
> +
> +static int
> +bpf_breakpoint_kind_from_pc (struct gdbarch *gdbarch, CORE_ADDR *start_pc)
> +{
> + /* We support just one kind of breakpoint. */
> + return 8;
Please document (or use a macro / const int to make it clear) that the kind is
also the instruction size.
IMO it would make more sense to call the first kind 0, and the subsequent ones
(if there is ever any) 1, 2, 3, etc, since you could have two breakpoint kinds
that have the same size.
Otherwise, this is OK.
Simon
next prev parent reply other threads:[~2020-08-01 23:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 12:24 [PATCH V5 0/3] eBPF support Jose E. Marchesi
2020-07-13 12:24 ` [PATCH V5 1/3] gdb: support for eBPF Jose E. Marchesi
2020-07-13 13:04 ` Eli Zaretskii
2020-07-13 13:30 ` Jose E. Marchesi
2020-08-01 23:25 ` Simon Marchi [this message]
2020-08-01 23:32 ` Simon Marchi
2020-07-13 12:24 ` [PATCH V5 2/3] sim: eBPF simulator Jose E. Marchesi
2020-07-13 12:24 ` [PATCH V5 3/3] sim: generated files for the " Jose E. Marchesi
2020-07-20 19:17 ` [PATCH V5 0/3] eBPF support Jose E. Marchesi
2020-08-01 23:16 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f6b4b0-e1cb-9d6b-9c55-2e37d78d3cb3@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jose.marchesi@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox