Re: [PATCH V5 1/3] gdb: support for eBPF

[Simon Marchi <simark@simark.ca>]

On 2020-08-01 7:25 p.m., Simon Marchi wrote:
> On 2020-07-13 8:24 a.m., Jose E. Marchesi via Gdb-patches wrote:
>> +/* Implement the breakpoint_kind_from_pc gdbarch method.  */
>> +
>> +static int
>> +bpf_breakpoint_kind_from_pc (struct gdbarch *gdbarch, CORE_ADDR *start_pc)
>> +{
>> +  /* We support just one kind of breakpoint.  */
>> +  return 8;
> 
> Please document (or use a macro / const int to make it clear) that the kind is
> also the instruction size.
> 
> IMO it would make more sense to call the first kind 0, and the subsequent ones
> (if there is ever any) 1, 2, 3, etc, since you could have two breakpoint kinds
> that have the same size.
> 
> Otherwise, this is OK.
> 
> Simon
> 

Oh, and would you like to add an entry in the MAINTAINERS file of GDB?  I suppose
it would make sense to have you there, unless you can think of somebody else?

Simon