Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Remove two cleanups using std::string
Date: Wed, 14 Mar 2018 01:32:00 -0000	[thread overview]
Message-ID: <d364c627-d382-f408-03ad-9c6fdb78d3b0@simark.ca> (raw)
In-Reply-To: <874lljtuhu.fsf@tromey.com>

On 2018-03-13 07:40 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
> 
> Simon> LGTM.  I would be more confident if that non-trivial escaping code was
> Simon> unit-tested, but I tried it by hand and it seems to do what it's supposed
> Simon> to do.
> 
> Yeah.  I looked at this briefly but it seemed like a lot of work for not
> a huge benefit.  Maybe if some other code was doing the same thing, it
> would make sense to pull this logic out into its own function.

Agreed.


      reply	other threads:[~2018-03-14  1:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 22:38 Tom Tromey
2018-03-13  2:37 ` Simon Marchi
2018-03-13 23:40   ` Tom Tromey
2018-03-14  1:32     ` Simon Marchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d364c627-d382-f408-03ad-9c6fdb78d3b0@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox