From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49096 invoked by alias); 14 Mar 2018 01:32:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49087 invoked by uid 89); 14 Mar 2018 01:32:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Mar 2018 01:32:13 +0000 Received: from [10.0.0.11] (192-222-251-162.qc.cable.ebox.net [192.222.251.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 79A741E4AE; Tue, 13 Mar 2018 21:32:11 -0400 (EDT) Subject: Re: [RFA] Remove two cleanups using std::string To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20180312223829.7108-1-tom@tromey.com> <874lljtuhu.fsf@tromey.com> From: Simon Marchi Message-ID: Date: Wed, 14 Mar 2018 01:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <874lljtuhu.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-03/txt/msg00276.txt.bz2 On 2018-03-13 07:40 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> LGTM. I would be more confident if that non-trivial escaping code was > Simon> unit-tested, but I tried it by hand and it seems to do what it's supposed > Simon> to do. > > Yeah. I looked at this briefly but it seemed like a lot of work for not > a huge benefit. Maybe if some other code was doing the same thing, it > would make sense to pull this logic out into its own function. Agreed.