Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Ivo Raisr <ivo.raisr@oracle.com>, Jiong Wang <jiong.wang@foss.arm.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: [Patch] New gdbarch method "dwarf_cfa_op" and migrate SPARC to it
Date: Wed, 26 Apr 2017 09:22:00 -0000	[thread overview]
Message-ID: <d20c56f3-2ea3-20f0-0ad4-4a2290025ed4@redhat.com> (raw)
In-Reply-To: <d0d44b09-39d5-4188-9fc5-b9b8b2358cd6@oracle.com>

On 04/26/2017 09:48 AM, Ivo Raisr wrote:
> 
> 
> On 25.4.2017 12:40, Jiong Wang wrote:
>> Thanks for the review.
>>
>> Ok for master? thanks
> 
> Updated patch was tested on sparc64-linux with no regressions.
> I.

Thanks Ivo.

In that case, patch is OK.  Please push.

(Please note that GDB puts rationale for changes in the git commit
log, not just a ChangeLog entry as GCC does in the svn logs.)

One tiny nit:

+		  if (!gdbarch_execute_dwarf_cfa_vendor_op (gdbarch, insn, fs))
+		    error (_("Call Frame Instruction %d in vendor extension "
+			     "space is not handled on this architecture."),
+			   insn);

here I'd suggest adding something like "insn " or "op " before the %d:

  Call Frame Instruction insn %d in ...
  Call Frame Instruction op %d in ...

Thanks,
Pedro Alves


      reply	other threads:[~2017-04-26  9:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 10:17 Jiong Wang
2017-04-21 20:45 ` Ivo Raisr
2017-04-21 18:33   ` Jiong Wang
2017-04-21 19:37     ` Pedro Alves
2017-04-21 19:53       ` Ivo Raisr
2017-04-25 10:40       ` Jiong Wang
2017-04-26  8:49         ` Ivo Raisr
2017-04-26  9:22           ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d20c56f3-2ea3-20f0-0ad4-4a2290025ed4@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ivo.raisr@oracle.com \
    --cc=jiong.wang@foss.arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox