From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-138618-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 36086 invoked by alias); 26 Apr 2017 09:22:25 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 36061 invoked by uid 89); 26 Apr 2017 09:22:24 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=tiny
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Apr 2017 09:22:19 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id A6EB761BB4;	Wed, 26 Apr 2017 09:22:20 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A6EB761BB4
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A6EB761BB4
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id B2AA117593;	Wed, 26 Apr 2017 09:22:18 +0000 (UTC)
Subject: Re: [Patch] New gdbarch method "dwarf_cfa_op" and migrate SPARC to it
To: Ivo Raisr <ivo.raisr@oracle.com>, Jiong Wang <jiong.wang@foss.arm.com>
References: <d6197185-945d-d90b-6eb9-729fa6d3705b@foss.arm.com> <edec7b0b-7f63-76f8-6546-d11c831e5058@oracle.com> <1d0d97ca-b503-0303-5efc-600db754bd27@foss.arm.com> <c92da4cc-a713-6055-f521-6164f5a6e6d8@palves.net> <cbf97c89-4c1f-8de3-8f25-60a7bae95454@foss.arm.com> <d0d44b09-39d5-4188-9fc5-b9b8b2358cd6@oracle.com>
Cc: GDB <gdb-patches@sourceware.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <d20c56f3-2ea3-20f0-0ad4-4a2290025ed4@redhat.com>
Date: Wed, 26 Apr 2017 09:22:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <d0d44b09-39d5-4188-9fc5-b9b8b2358cd6@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-04/txt/msg00702.txt.bz2

On 04/26/2017 09:48 AM, Ivo Raisr wrote:
> 
> 
> On 25.4.2017 12:40, Jiong Wang wrote:
>> Thanks for the review.
>>
>> Ok for master? thanks
> 
> Updated patch was tested on sparc64-linux with no regressions.
> I.

Thanks Ivo.

In that case, patch is OK.  Please push.

(Please note that GDB puts rationale for changes in the git commit
log, not just a ChangeLog entry as GCC does in the svn logs.)

One tiny nit:

+		  if (!gdbarch_execute_dwarf_cfa_vendor_op (gdbarch, insn, fs))
+		    error (_("Call Frame Instruction %d in vendor extension "
+			     "space is not handled on this architecture."),
+			   insn);

here I'd suggest adding something like "insn " or "op " before the %d:

  Call Frame Instruction insn %d in ...
  Call Frame Instruction op %d in ...

Thanks,
Pedro Alves