Re: [PATCH v2][PR gdb/18706] Calculate size of array of stubbed type

[Tom de Vries <tdevries@suse.de>]

On 30-04-2020 18:23, Hannes Domani via Gdb-patches wrote:
>  Am Donnerstag, 30. April 2020, 18:14:26 MESZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:
> 
>> On 2020-04-30 9:09 a.m., Hannes Domani via Gdb-patches wrote:
>>
>>> Sizes of stubbed types are calculated on demand in check_typedef, so the
>>> same must also be done for arrays of stubbed types.
>>>
>>> A stubbed type is usually a structure that has only been forward declared,
>>> but can also happen if the structure has a virtual function that's not
>>> inline in the class definition.
>>>
>>> For these stubbed types, the size must be recalculated once the full
>>> definition is available.
>>
>>
>> Thanks, this is OK.
> 
> Pushed, thanks.

Hi,

This caused:
...
FAIL: gdb.fortran/array-slices.exp: test 2: p array
FAIL: gdb.fortran/array-slices.exp: test 3: p array
FAIL: gdb.fortran/array-slices.exp: test 4: p array
FAIL: gdb.fortran/array-slices.exp: test 5: p array
FAIL: gdb.fortran/array-slices.exp: test 7: p array
FAIL: gdb.fortran/array-slices.exp: test 8: p array
FAIL: gdb.fortran/vla-alloc-assoc.exp: print deallocated vla1
FAIL: gdb.fortran/vla-alloc-assoc.exp: print deallocated vla2
FAIL: gdb.fortran/vla-type.exp: print twov before allocated
FAIL: gdb.fortran/vla-type.exp: print twov%ivla1 before allocated
FAIL: gdb.fortran/vla-ptype.exp: ptype pvla(5, 45, 20) not associated
FAIL: gdb.fortran/vla-ptype.exp: ptype vla1(3, 6, 9) not allocated
FAIL: gdb.fortran/vla-ptype.exp: ptype vla2(5, 45, 20) not allocated
FAIL: gdb.fortran/derived-type-striding.exp: p point_dimension
FAIL: gdb.fortran/derived-type-striding.exp: p point_mixed_dimension
FAIL: gdb.fortran/vla-value-sub.exp: print passed array1 in foo (passed
sub-array)
FAIL: gdb.fortran/vla-value-sub.exp: print array1(5, 5) after filled in
foo (passed sub-array)
FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was
filled (passed sub-array)
FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was
mofified in debugger (passed sub-array)
FAIL: gdb.fortran/vla-ptype-sub.exp: ptype array1(3, 3) (passed sub-array)
FAIL: gdb.fortran/vla-ptype-sub.exp: ptype array2(4, 4, 4) (passed
sub-array)
FAIL: gdb.fortran/vla-value.exp: print undefined pvla
FAIL: gdb.fortran/vla-value.exp: print pvla(5, 45, 20) after deassociated
FAIL: gdb.fortran/vla-value.exp: print pvla(7, 45, 14) after dissasociated
FAIL: gdb.fortran/vla-value.exp: print vla1 after deassociated
FAIL: gdb.fortran/vla-value.exp: print allocated vla1(3,6,9) after
specific assignment (deallocated)
FAIL: gdb.fortran/vla-value.exp: print allocated vla1(1,3,8) after
specific assignment (deallocated)
FAIL: gdb.fortran/vla-value.exp: print allocated vla1(9,9,9) after
assignment in debugger (deallocated)
FAIL: gdb.mi/mi-vla-fortran.exp: evaluate not allocated vla, before
allocation (unexpected output)
FAIL: gdb.mi/mi-vla-fortran.exp: eval variable vla1_not_allocated
(unexpected output)
FAIL: gdb.mi/mi-vla-fortran.exp: get children of vla1_not_allocated
(unexpected output)
FAIL: gdb.mi/mi-vla-fortran.exp: evaluate not allocated vla, after
deallocation (unexpected output)
FAIL: gdb.mi/mi-vla-fortran.exp: evaluate vla pointer set to null
(unexpected output)
...

Thanks,
- Tom