From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id B8A9D396E449 for ; Thu, 30 Apr 2020 22:01:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8A9D396E449 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 548EDAF55; Thu, 30 Apr 2020 22:01:38 +0000 (UTC) Subject: Re: [PATCH v2][PR gdb/18706] Calculate size of array of stubbed type To: Hannes Domani , Gdb-patches References: <20200430130954.15121-1-ssbssa.ref@yahoo.de> <20200430130954.15121-1-ssbssa@yahoo.de> <3c4480f8-eb62-1aed-0f0f-c87c234680ad@simark.ca> <1035526999.5686211.1588263831423@mail.yahoo.com> From: Tom de Vries Autocrypt: addr=tdevries@suse.de; keydata= xsBNBF0ltCcBCADDhsUnMMdEXiHFfqJdXeRvgqSEUxLCy/pHek88ALuFnPTICTwkf4g7uSR7 HvOFUoUyu8oP5mNb4VZHy3Xy8KRZGaQuaOHNhZAT1xaVo6kxjswUi3vYgGJhFMiLuIHdApoc u5f7UbV+egYVxmkvVLSqsVD4pUgHeSoAcIlm3blZ1sDKviJCwaHxDQkVmSsGXImaAU+ViJ5l CwkvyiiIifWD2SoOuFexZyZ7RUddLosgsO0npVUYbl6dEMq2a5ijGF6/rBs1m3nAoIgpXk6P TCKlSWVW6OCneTaKM5C387972qREtiArTakRQIpvDJuiR2soGfdeJ6igGA1FZjU+IsM5ABEB AAHNH1RvbSBkZSBWcmllcyA8dGRldnJpZXNAc3VzZS5kZT7CwKsEEwEIAD4WIQSsnSe5hKbL MK1mGmjuhV2rbOJEoAUCXSW0JwIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAh CRDuhV2rbOJEoBYhBKydJ7mEpsswrWYaaO6FXats4kSgc48H/Ra2lq5p3dHsrlQLqM7N68Fo eRDf3PMevXyMlrCYDGLVncQwMw3O/AkousktXKQ42DPJh65zoXB22yUt8m0g12xkLax98KFJ 5NyUloa6HflLl+wQL/uZjIdNUQaHQLw3HKwRMVi4l0/Jh/TygYG1Dtm8I4o708JS4y8GQxoQ UL0z1OM9hyM3gI2WVTTyprsBHy2EjMOu/2Xpod95pF8f90zBLajy6qXEnxlcsqreMaqmkzKn 3KTZpWRxNAS/IH3FbGQ+3RpWkNGSJpwfEMVCeyK5a1n7yt1podd1ajY5mA1jcaUmGppqx827 8TqyteNe1B/pbiUt2L/WhnTgW1NC1QDOwE0EXSW0JwEIAM99H34Bu4MKM7HDJVt864MXbx7B 1M93wVlpJ7Uq+XDFD0A0hIal028j+h6jA6bhzWto4RUfDl/9mn1StngNVFovvwtfzbamp6+W pKHZm9X5YvlIwCx131kTxCNDcF+/adRW4n8CU3pZWYmNVqhMUiPLxElA6QhXTtVBh1RkjCZQ Kmbd1szvcOfaD8s+tJABJzNZsmO2hVuFwkDrRN8Jgrh92a+yHQPd9+RybW2l7sJv26nkUH5Z 5s84P6894ebgimcprJdAkjJTgprl1nhgvptU5M9Uv85Pferoh2groQEAtRPlCGrZ2/2qVNe9 XJfSYbiyedvApWcJs5DOByTaKkcAEQEAAcLAkwQYAQgAJhYhBKydJ7mEpsswrWYaaO6FXats 4kSgBQJdJbQnAhsMBQkDwmcAACEJEO6FXats4kSgFiEErJ0nuYSmyzCtZhpo7oVdq2ziRKD3 twf7BAQBZ8TqR812zKAD7biOnWIJ0McV72PFBxmLIHp24UVe0ZogtYMxSWKLg3csh0yLVwc7 H3vldzJ9AoK3Qxp0Q6K/rDOeUy3HMqewQGcqrsRRh0NXDIQk5CgSrZslPe47qIbe3O7ik/MC q31FNIAQJPmKXX25B115MMzkSKlv4udfx7KdyxHrTSkwWZArLQiEZj5KG4cCKhIoMygPTA3U yGaIvI/BGOtHZ7bEBVUCFDFfOWJ26IOCoPnSVUvKPEOH9dv+sNy7jyBsP5QxeTqwxC/1ZtNS DUCSFQjqA6bEGwM22dP8OUY6SC94x1G81A9/xbtm9LQxKm0EiDH8KBMLfQ== Message-ID: Date: Fri, 1 May 2020 00:01:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1035526999.5686211.1588263831423@mail.yahoo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Apr 2020 22:01:41 -0000 On 30-04-2020 18:23, Hannes Domani via Gdb-patches wrote: > Am Donnerstag, 30. April 2020, 18:14:26 MESZ hat Simon Marchi Folgendes geschrieben: > >> On 2020-04-30 9:09 a.m., Hannes Domani via Gdb-patches wrote: >> >>> Sizes of stubbed types are calculated on demand in check_typedef, so the >>> same must also be done for arrays of stubbed types. >>> >>> A stubbed type is usually a structure that has only been forward declared, >>> but can also happen if the structure has a virtual function that's not >>> inline in the class definition. >>> >>> For these stubbed types, the size must be recalculated once the full >>> definition is available. >> >> >> Thanks, this is OK. > > Pushed, thanks. Hi, This caused: ... FAIL: gdb.fortran/array-slices.exp: test 2: p array FAIL: gdb.fortran/array-slices.exp: test 3: p array FAIL: gdb.fortran/array-slices.exp: test 4: p array FAIL: gdb.fortran/array-slices.exp: test 5: p array FAIL: gdb.fortran/array-slices.exp: test 7: p array FAIL: gdb.fortran/array-slices.exp: test 8: p array FAIL: gdb.fortran/vla-alloc-assoc.exp: print deallocated vla1 FAIL: gdb.fortran/vla-alloc-assoc.exp: print deallocated vla2 FAIL: gdb.fortran/vla-type.exp: print twov before allocated FAIL: gdb.fortran/vla-type.exp: print twov%ivla1 before allocated FAIL: gdb.fortran/vla-ptype.exp: ptype pvla(5, 45, 20) not associated FAIL: gdb.fortran/vla-ptype.exp: ptype vla1(3, 6, 9) not allocated FAIL: gdb.fortran/vla-ptype.exp: ptype vla2(5, 45, 20) not allocated FAIL: gdb.fortran/derived-type-striding.exp: p point_dimension FAIL: gdb.fortran/derived-type-striding.exp: p point_mixed_dimension FAIL: gdb.fortran/vla-value-sub.exp: print passed array1 in foo (passed sub-array) FAIL: gdb.fortran/vla-value-sub.exp: print array1(5, 5) after filled in foo (passed sub-array) FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was filled (passed sub-array) FAIL: gdb.fortran/vla-value-sub.exp: print array2 in foo after it was mofified in debugger (passed sub-array) FAIL: gdb.fortran/vla-ptype-sub.exp: ptype array1(3, 3) (passed sub-array) FAIL: gdb.fortran/vla-ptype-sub.exp: ptype array2(4, 4, 4) (passed sub-array) FAIL: gdb.fortran/vla-value.exp: print undefined pvla FAIL: gdb.fortran/vla-value.exp: print pvla(5, 45, 20) after deassociated FAIL: gdb.fortran/vla-value.exp: print pvla(7, 45, 14) after dissasociated FAIL: gdb.fortran/vla-value.exp: print vla1 after deassociated FAIL: gdb.fortran/vla-value.exp: print allocated vla1(3,6,9) after specific assignment (deallocated) FAIL: gdb.fortran/vla-value.exp: print allocated vla1(1,3,8) after specific assignment (deallocated) FAIL: gdb.fortran/vla-value.exp: print allocated vla1(9,9,9) after assignment in debugger (deallocated) FAIL: gdb.mi/mi-vla-fortran.exp: evaluate not allocated vla, before allocation (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: eval variable vla1_not_allocated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: get children of vla1_not_allocated (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: evaluate not allocated vla, after deallocation (unexpected output) FAIL: gdb.mi/mi-vla-fortran.exp: evaluate vla pointer set to null (unexpected output) ... Thanks, - Tom