From: Simon Marchi <simon.marchi@polymtl.ca>
To: Weimin Pan <weimin.pan@oracle.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4 PR gdb/16959] gdb hangs in infinite recursion
Date: Tue, 27 Mar 2018 03:28:00 -0000 [thread overview]
Message-ID: <d06282f1004b70501a7ba557e6174c9b@polymtl.ca> (raw)
In-Reply-To: <1522101276-114428-1-git-send-email-weimin.pan@oracle.com>
On 2018-03-26 17:54, Weimin Pan wrote:
> @@ -658,15 +659,14 @@ cp_print_static_field (struct type *type,
> addr = value_address (val);
> obstack_grow (&dont_print_statmem_obstack, (char *) &addr,
> sizeof (CORE_ADDR));
> - type = check_typedef (type);
> - cp_print_value_fields (type, value_enclosing_type (val),
> + cp_print_value_fields (real_type, value_enclosing_type (val),
As discussed previously, here we should pass the original type.
Btw, if you now have push access to the git repo, you should add
yourself in the "Write After Approval" section of the gdb/MAINTAINERS
file. This will help you make sure everything is set up correctly.
Don't forget to include a ChangeLog entry for it and post the patch on
the mailing list afterwards (mentioning that you have pushed it), you
can inspire yourself from how people have done it in the past.
Simon
next prev parent reply other threads:[~2018-03-27 3:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 22:20 Weimin Pan
2018-03-27 3:28 ` Simon Marchi [this message]
2018-03-27 19:54 ` Weimin Pan
2018-03-27 20:49 ` Simon Marchi
2018-03-27 22:03 ` Weimin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d06282f1004b70501a7ba557e6174c9b@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=weimin.pan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox