From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118008 invoked by alias); 27 Mar 2018 03:28:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117970 invoked by uid 89); 27 Mar 2018 03:28:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*u:1.3.4, H*UA:1.3.4 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Mar 2018 03:28:12 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w2R3S68s007014 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 26 Mar 2018 23:28:10 -0400 Received: by simark.ca (Postfix, from userid 112) id E92BD1E77E; Mon, 26 Mar 2018 23:28:05 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 497CE1E073; Mon, 26 Mar 2018 23:28:05 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 27 Mar 2018 03:28:00 -0000 From: Simon Marchi To: Weimin Pan Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 4 PR gdb/16959] gdb hangs in infinite recursion In-Reply-To: <1522101276-114428-1-git-send-email-weimin.pan@oracle.com> References: <1522101276-114428-1-git-send-email-weimin.pan@oracle.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 27 Mar 2018 03:28:06 +0000 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00549.txt.bz2 On 2018-03-26 17:54, Weimin Pan wrote: > @@ -658,15 +659,14 @@ cp_print_static_field (struct type *type, > addr = value_address (val); > obstack_grow (&dont_print_statmem_obstack, (char *) &addr, > sizeof (CORE_ADDR)); > - type = check_typedef (type); > - cp_print_value_fields (type, value_enclosing_type (val), > + cp_print_value_fields (real_type, value_enclosing_type (val), As discussed previously, here we should pass the original type. Btw, if you now have push access to the git repo, you should add yourself in the "Write After Approval" section of the gdb/MAINTAINERS file. This will help you make sure everything is set up correctly. Don't forget to include a ChangeLog entry for it and post the patch on the mailing list afterwards (mentioning that you have pushed it), you can inspire yourself from how people have done it in the past. Simon