From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Simplify DWARF reader initialization
Date: Sun, 28 Mar 2021 12:06:10 -0400 [thread overview]
Message-ID: <d02e076e-34c9-e2f4-02ac-3b748637e02d@polymtl.ca> (raw)
In-Reply-To: <20210327230318.582968-1-tom@tromey.com>
On 2021-03-27 7:03 p.m., Tom Tromey wrote:
> Now that the quick functions are separate from the object file format,
> there's no need to have elfread.c push a new entry on the objfile 'qf'
> list. Instead, this detail can be pushed into the DWARF reader. That
> is what this patch implements.
>
> I wasn't sure whether lazy reading still makes sense or not. It's
> still only used by ELF, and only in certain situations (like vfork, I
> think). It may not be carrying its weight, so we may want to consider
> removing this in the future.
>
> Also, I'm unclear on why the various indices are only used for ELF.
> This seems sub-optimal. However, I haven't tried to address that
> here.
I think this makes sense, I always found weird that part of elfread.c that
knew too much about the dwarf reader.
Simon
next prev parent reply other threads:[~2021-03-28 16:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 23:03 Tom Tromey
2021-03-28 16:06 ` Simon Marchi via Gdb-patches [this message]
2021-03-28 16:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02e076e-34c9-e2f4-02ac-3b748637e02d@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox