From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IZUeAH2pYGDSKQAAWB0awg (envelope-from ) for ; Sun, 28 Mar 2021 12:06:21 -0400 Received: by simark.ca (Postfix, from userid 112) id E6BD31E939; Sun, 28 Mar 2021 12:06:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F32D1E01F for ; Sun, 28 Mar 2021 12:06:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AC204385703C; Sun, 28 Mar 2021 16:06:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AC204385703C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1616947579; bh=YLAvVJyYJSmUJ6iDDr/LxB9ExO4eLra5c4BiLv/Fqd4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=nG7ZXNLbercwhbSr6v4yXcMDtsNU5q1ovAnDMU/xFB0N5arIGYnS1TMTJMPOTI3Sk +oFmCwxPX4Vc6ax9wk1eO15N4NKyicS3U6OhRCmjSGufjX/sNuhcoz9bvVJcjMBSgE buy0/AXbjJwtX17SubzWZvEBBtGiOR/RzuCKfA+I= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C52E6385703C for ; Sun, 28 Mar 2021 16:06:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C52E6385703C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 12SG6Bei028121 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 28 Mar 2021 12:06:16 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 12SG6Bei028121 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3A6891E01F; Sun, 28 Mar 2021 12:06:11 -0400 (EDT) Subject: Re: [PATCH] Simplify DWARF reader initialization To: Tom Tromey , gdb-patches@sourceware.org References: <20210327230318.582968-1-tom@tromey.com> Message-ID: Date: Sun, 28 Mar 2021 12:06:10 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210327230318.582968-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 28 Mar 2021 16:06:11 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-27 7:03 p.m., Tom Tromey wrote: > Now that the quick functions are separate from the object file format, > there's no need to have elfread.c push a new entry on the objfile 'qf' > list. Instead, this detail can be pushed into the DWARF reader. That > is what this patch implements. > > I wasn't sure whether lazy reading still makes sense or not. It's > still only used by ELF, and only in certain situations (like vfork, I > think). It may not be carrying its weight, so we may want to consider > removing this in the future. > > Also, I'm unclear on why the various indices are only used for ELF. > This seems sub-optimal. However, I haven't tried to address that > here. I think this makes sense, I always found weird that part of elfread.c that knew too much about the dwarf reader. Simon