From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Дилян Палаузов" <dilyan.palauzov@aegee.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Linking gdb with -ltinfow, if libtinfo is not available
Date: Wed, 05 Dec 2018 14:49:00 -0000 [thread overview]
Message-ID: <d02c84140a12753faf4c036e22b85520@polymtl.ca> (raw)
In-Reply-To: <30919bd86dea123f624ccd1f069aff432622fb6e.camel@aegee.org>
On 2018-12-05 02:22, ÐилÑн ÐалаÑзов wrote:
> See https://sourceware.org/bugzilla/show_bug.cgi?id=23950 for details.
>
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -592,7 +592,7 @@ case $host_os in
> esac
>
> # These are the libraries checked by Readline.
> -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
> +AC_SEARCH_LIBS(tgetent, [termcap tinfo tinfow curses ncursesw
> ncurses])
>
> if test "$ac_cv_search_tgetent" = no; then
> CONFIG_OBS="$CONFIG_OBS stub-termcap.o"
I am not able to test this (since all my systems have a libtinfo.so,
which gets picked up), but I think it makes sense. If you have a system
where the only ncurses available is configured with:
--with-termlib --with-shared --enable-widec
you end up with libtinfow.so and no libtinfo.so. Any objections? I can
take care of ChangeLog and commit message since it is a very small
change, but next time please make sure to follow the checklist [1].
Thanks,
Simon
[1] https://sourceware.org/gdb/wiki/ContributionChecklist
next prev parent reply other threads:[~2018-12-05 14:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 7:23 Дилян Палаузов
2018-12-05 14:49 ` Simon Marchi [this message]
2018-12-05 16:42 ` Дилян Палаузов
2018-12-05 19:59 ` Simon Marchi
2018-12-05 23:09 ` Дилян Палаузов
2018-12-09 0:44 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02c84140a12753faf4c036e22b85520@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=dilyan.palauzov@aegee.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox