Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: "Дилян Палаузов" <dilyan.palauzov@aegee.org>,
	"Simon Marchi" <simon.marchi@polymtl.ca>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: Linking gdb with -ltinfow, if libtinfo is not available
Date: Wed, 05 Dec 2018 19:59:00 -0000	[thread overview]
Message-ID: <b4faf4a1-f2b1-304a-2f96-ff86fbaaa44f@ericsson.com> (raw)
In-Reply-To: <f295f4ee20c27903dc499bcf6a4c68519bf8bc51.camel@aegee.org>

On 2018-12-05 11:41 a.m., Дилян Палаузов wrote:
> Hello,
> 
> you should be able to test this by having libtinfo.so in a directory,
> that is not introduced to the linker by -L and is not default for the
> compiller or linker and have libtinfow.so in а path passed by -L;
> possibly moving libtinfo.so to a location that is still considered by
> ldconfig.

I tested this in a docker container, as to avoid messing up my system.  I
deleted all traces of libtinfo.so, compiled and installed ncurses by hand with

  --with-termlib --with-shared --enable-widec --prefix=/usr

which got me a libtinfow.so.  I was then able to reproduce the linking
problem and confirm that your patch works (we just need to re-generate
configure).

So here's what I propose pushing.  My cyrillic is not totally on point,
does your name look good in the ChangeLog entry below?  Or would you
prefer to have a romanized version in there?


From 70670e00263468aa36dce313d2241b5f953596af Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Wed, 5 Dec 2018 14:21:31 -0500
Subject: [PATCH] Look for tgetent in libtinfow
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On some systems where ncurses is only available in the "wide" version
(compiled with --with-widec), there might be no libtinfo.so, only a
libtinfow.so.  Look for libtinfow in addition to libtinfo.

gdb/ChangeLog:

YYYY-MM-DD  Simon Marchi  <simon.marchi@ericsson.com>
	    Дилян Палаузов  <dilyan.palauzov@aegee.org>

	PR gdb/23950
	* configure.ac: Search for tgetent in libtinfow.
	* configure: Re-generate.
---
 gdb/configure    | 2 +-
 gdb/configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/configure b/gdb/configure
index 7665ba65319..603c413fe8e 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -9027,7 +9027,7 @@ return tgetent ();
   return 0;
 }
 _ACEOF
-for ac_lib in '' termcap tinfo curses ncursesw ncurses; do
+for ac_lib in '' termcap tinfow tinfo curses ncursesw ncurses; do
   if test -z "$ac_lib"; then
     ac_res="none required"
   else
diff --git a/gdb/configure.ac b/gdb/configure.ac
index e1ea60660b9..b40c53a06cd 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -592,7 +592,7 @@ case $host_os in
 esac

 # These are the libraries checked by Readline.
-AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
+AC_SEARCH_LIBS(tgetent, [termcap tinfow tinfo curses ncursesw ncurses])

 if test "$ac_cv_search_tgetent" = no; then
   CONFIG_OBS="$CONFIG_OBS stub-termcap.o"
-- 
2.19.2


  reply	other threads:[~2018-12-05 19:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  7:23 Дилян Палаузов
2018-12-05 14:49 ` Simon Marchi
2018-12-05 16:42   ` Дилян Палаузов
2018-12-05 19:59     ` Simon Marchi [this message]
2018-12-05 23:09       ` Дилян Палаузов
2018-12-09  0:44         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4faf4a1-f2b1-304a-2f96-ff86fbaaa44f@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=dilyan.palauzov@aegee.org \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox