[PATCH v4 0/2] Breakpoint conditions at locations with differing contexts

[Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>]

Hi,

This is a follow-up of

  https://sourceware.org/pipermail/gdb-patches/2020-July/170984.html

which is a short series about conditional breakpoints where the
condition may be invalid at some breakpoint locations because of their
context.  Currently, GDB does not allow defining a condition if it's
not valid at all locations.  This series aims at bringing more
flexibility: the locations at which the condition expression is
invalid are disabled automatically.

In v2, I extended Patch 2/2 with the '-force-condition' flag for the break
command, added test cases and more documentation.

In v3, warning messages are updated based on Simon Marchi's
comments at https://sourceware.org/pipermail/gdb-patches/2020-September/171970.html.
I also revised the documentation changes.

In this revision (v4), the updates are as follows:

* Rebased on the current master.

* Correct location number is printed if a location is disabled
  because of the invalid condition when the breakpoint is being
  defined for the first time.

* A legend is shown at the bottom of the breakpoint table to explain
  the meaning of "N*".

* A long warning message is broken into two lines.

Regards.
Baris

Tankut Baris Aktemur (2):
  gdb/breakpoint: disable a bp location if condition is invalid at that
    location
  gdb/breakpoint: add flags to 'condition' and 'break' commands to force
    condition

 gdb/ada-lang.c                                |   2 +-
 gdb/breakpoint.c                              | 283 ++++++++++++++----
 gdb/breakpoint.h                              |  12 +-
 gdb/doc/gdb.texinfo                           |  70 +++++
 gdb/guile/scm-breakpoint.c                    |   2 +-
 gdb/linespec.c                                |  18 +-
 gdb/python/py-breakpoint.c                    |   2 +-
 .../gdb.base/condbreak-multi-context.cc       |  54 ++++
 .../gdb.base/condbreak-multi-context.exp      | 255 ++++++++++++++++
 gdb/testsuite/gdb.linespec/cpcompletion.exp   |  12 +-
 gdb/testsuite/gdb.linespec/explicit.exp       |   1 +
 gdb/testsuite/lib/completion-support.exp      |   2 +-
 12 files changed, 644 insertions(+), 69 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/condbreak-multi-context.cc
 create mode 100644 gdb/testsuite/gdb.base/condbreak-multi-context.exp

-- 
2.17.1