From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yOk9ELKchV/GBgAAWB0awg (envelope-from ) for ; Tue, 13 Oct 2020 08:25:22 -0400 Received: by simark.ca (Postfix, from userid 112) id 3EFDA1EF6F; Tue, 13 Oct 2020 08:25:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E1F721E58D for ; Tue, 13 Oct 2020 08:25:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5AA7E388A83C; Tue, 13 Oct 2020 12:25:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AA7E388A83C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602591921; bh=hiKXyJQXyWXFWrWH+xC/QabB5Tov7xOAstxG3z6y9O8=; h=To:Subject:Date:In-Reply-To:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:From; b=BEFVXH6IQ6x6DxV/izUE8MDkbtr15Cc9bpMRAzZwnL2Aj6cRof+Nht0nlYzRxmoJ+ K2XPFs8anjW05Gx/VzHZ5Sne9k8AwBEYJcq1IDTpC/qxvTO6PBSzLywpJHLxBeDvHy Ai22gXM3J6BmL1bOM/jlQbzs+NlH7BnPS/YJxin0= Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id A3DB83851C0E for ; Tue, 13 Oct 2020 12:25:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A3DB83851C0E IronPort-SDR: Lh0tDint+X5rsCjqn0ACo39igOMoyWZKQio7NtCbr+NIn6SANY4ximWol+oR7ijqHuDkpsk4RD 0IJ2588ImEKA== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="166011680" X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="166011680" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 05:25:17 -0700 IronPort-SDR: 8cZt7hD3OG9fV0aW+X44wAn0pWC6EbOtI329cqpPBvHWSI4Bl6Ub/uBi7vH7V+QS7vnIcXtIam ASrku2kfbqlw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="420517066" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga001.fm.intel.com with ESMTP; 13 Oct 2020 05:25:15 -0700 Received: from ulvlx001.iul.intel.com (ulvlx001.iul.intel.com [172.28.207.17]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 09DCPFO9030893; Tue, 13 Oct 2020 13:25:15 +0100 Received: from ulvlx001.iul.intel.com (localhost [127.0.0.1]) by ulvlx001.iul.intel.com with ESMTP id 09DCPFV8010360; Tue, 13 Oct 2020 14:25:15 +0200 Received: (from taktemur@localhost) by ulvlx001.iul.intel.com with LOCAL id 09DCPEPT010356; Tue, 13 Oct 2020 14:25:14 +0200 To: gdb-patches@sourceware.org Subject: [PATCH v4 0/2] Breakpoint conditions at locations with differing contexts Date: Tue, 13 Oct 2020 14:25:01 +0200 Message-Id: X-Mailer: git-send-email 1.7.0.7 In-Reply-To: X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tankut Baris Aktemur via Gdb-patches Reply-To: Tankut Baris Aktemur Cc: simark@simark.ca Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi, This is a follow-up of https://sourceware.org/pipermail/gdb-patches/2020-July/170984.html which is a short series about conditional breakpoints where the condition may be invalid at some breakpoint locations because of their context. Currently, GDB does not allow defining a condition if it's not valid at all locations. This series aims at bringing more flexibility: the locations at which the condition expression is invalid are disabled automatically. In v2, I extended Patch 2/2 with the '-force-condition' flag for the break command, added test cases and more documentation. In v3, warning messages are updated based on Simon Marchi's comments at https://sourceware.org/pipermail/gdb-patches/2020-September/171970.html. I also revised the documentation changes. In this revision (v4), the updates are as follows: * Rebased on the current master. * Correct location number is printed if a location is disabled because of the invalid condition when the breakpoint is being defined for the first time. * A legend is shown at the bottom of the breakpoint table to explain the meaning of "N*". * A long warning message is broken into two lines. Regards. Baris Tankut Baris Aktemur (2): gdb/breakpoint: disable a bp location if condition is invalid at that location gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition gdb/ada-lang.c | 2 +- gdb/breakpoint.c | 283 ++++++++++++++---- gdb/breakpoint.h | 12 +- gdb/doc/gdb.texinfo | 70 +++++ gdb/guile/scm-breakpoint.c | 2 +- gdb/linespec.c | 18 +- gdb/python/py-breakpoint.c | 2 +- .../gdb.base/condbreak-multi-context.cc | 54 ++++ .../gdb.base/condbreak-multi-context.exp | 255 ++++++++++++++++ gdb/testsuite/gdb.linespec/cpcompletion.exp | 12 +- gdb/testsuite/gdb.linespec/explicit.exp | 1 + gdb/testsuite/lib/completion-support.exp | 2 +- 12 files changed, 644 insertions(+), 69 deletions(-) create mode 100644 gdb/testsuite/gdb.base/condbreak-multi-context.cc create mode 100644 gdb/testsuite/gdb.base/condbreak-multi-context.exp -- 2.17.1