From: Andrew Burgess <andrew.burgess@embecosm.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>, Hannes Domani <ssbssa@yahoo.de>,
Andrew Burgess <andrew.burgess@embecosm.com>
Subject: [PATCH 0/6] Vertical scrolling and another small bug fix
Date: Tue, 07 Jan 2020 11:52:00 -0000 [thread overview]
Message-ID: <cover.1578397591.git.andrew.burgess@embecosm.com> (raw)
In-Reply-To: <874kxrc3ha.fsf@tromey.com>
Here's a series that fixes the vertical scrolling issue. It
incorporates your proposed fix (with a small testsuite change), and
then builds upon it.
This is a different (simpler) approach than I originally suggested.
I'm still not really happy with how the tui keeps track and displays
the current symtab_and_line; I think there's many places that GDB
should do a better job of placing the "current" location in the centre
of the screen, where currently it has a tendency to jam the current
location right at the top.
However, I think leaving the ability to vertically scroll broken isn't
good, and I think this series is a step in the right direction
(maybe?).
Thoughts / comments welcome.
Thanks,
Andrew
--
Andrew Burgess (5):
gdb/testsuite/tui: Always dump_screen when asked
gdb/testsuite/tui: Split enter_tui into two procs
gdb/testsuite/tui: Introduce check_box_contents
gdb/tui: Fix 'layout asm' before the inferior has started
gdb/tui: Link source and assembler scrolling .... again
Tom Tromey (1):
gdb: Fix scrolling in TUI
gdb/ChangeLog | 17 ++++++++
gdb/testsuite/ChangeLog | 30 ++++++++++++++
gdb/testsuite/gdb.tui/basic.exp | 40 +++++++++++++++++++
gdb/testsuite/gdb.tui/tui-layout-asm.exp | 34 ++++++++++++++++
gdb/testsuite/lib/tuiterm.exp | 67 ++++++++++++++++++++++++++------
gdb/tui/tui-source.c | 27 +++++++------
gdb/tui/tui.c | 10 +++--
7 files changed, 199 insertions(+), 26 deletions(-)
create mode 100644 gdb/testsuite/gdb.tui/tui-layout-asm.exp
--
2.14.5
next prev parent reply other threads:[~2020-01-07 11:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191221153325.6961-1-ssbssa.ref@yahoo.de>
2019-12-21 15:34 ` [RFC][PATCH] Call tui_before_prompt in do_scroll_vertical Hannes Domani via gdb-patches
2019-12-22 0:58 ` Andrew Burgess
2019-12-22 1:25 ` Hannes Domani via gdb-patches
2019-12-23 0:03 ` Tom Tromey
2019-12-23 0:19 ` Hannes Domani via gdb-patches
2019-12-23 1:23 ` Andrew Burgess
2020-01-07 11:52 ` [PATCH 2/6] gdb/testsuite/tui: Split enter_tui into two procs Andrew Burgess
2020-01-07 19:19 ` Tom Tromey
2020-01-07 11:52 ` [PATCH 5/6] gdb: Fix scrolling in TUI Andrew Burgess
2020-01-07 19:36 ` Tom Tromey
2020-01-07 11:52 ` [PATCH 4/6] gdb/tui: Fix 'layout asm' before the inferior has started Andrew Burgess
2020-01-07 19:31 ` Tom Tromey
2020-01-07 11:52 ` Andrew Burgess [this message]
2020-01-07 19:38 ` [PATCH 0/6] Vertical scrolling and another small bug fix Tom Tromey
2020-01-09 23:28 ` Andrew Burgess
2020-01-07 11:52 ` [PATCH 6/6] gdb/tui: Link source and assembler scrolling .... again Andrew Burgess
2020-01-07 19:37 ` Tom Tromey
2020-01-07 11:52 ` [PATCH 3/6] gdb/testsuite/tui: Introduce check_box_contents Andrew Burgess
2020-01-07 19:30 ` Tom Tromey
2020-01-07 11:52 ` [PATCH 1/6] gdb/testsuite/tui: Always dump_screen when asked Andrew Burgess
2020-01-07 18:54 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1578397591.git.andrew.burgess@embecosm.com \
--to=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox