From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22033 invoked by alias); 7 Jan 2020 11:52:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21966 invoked by uid 89); 7 Jan 2020 11:52:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=vertical, H*m:andrew, screen X-HELO: mail-wm1-f45.google.com Received: from mail-wm1-f45.google.com (HELO mail-wm1-f45.google.com) (209.85.128.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2020 11:52:26 +0000 Received: by mail-wm1-f45.google.com with SMTP id p17so19096473wmb.0 for ; Tue, 07 Jan 2020 03:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ir2zwRoyEZyl4e/MEf6Ms+paoyHjhiVmf+WhvaqZopQ=; b=JE1Mc2RVwpboGphGfVaXVXU20l/3nXAYxZD55SrnHwhwcv6gUb120UwregRTmUM87o w87jEJI981UBsBydW+zr9P4xVUOI5FXJ+88N1JfH65aZ7oGUvimPjQeKjzTqn7jkE3Jd D5Por14zO+n/9XMPHCP0iXM+hqK6j10B7InruszWhHWYC8zcLHk4zF5Vi03IGvHqk5V+ ARdr/2n6szyQB9soXN9FO97QX2/p/8GQHRl6IBQODoyNl2a5zgCu1cptbo0UbZw7Muxk LR+5+rzteu9wiVPDnAQfANopCM+d2D/yGUHcWiyQ97pu+yb7+cJ8VmBS9exL4orFMp30 kHOg== Return-Path: Received: from localhost (host86-186-80-236.range86-186.btcentralplus.com. [86.186.80.236]) by smtp.gmail.com with ESMTPSA id n187sm26623813wme.28.2020.01.07.03.52.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 Jan 2020 03:52:23 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Tom Tromey , Hannes Domani , Andrew Burgess Subject: [PATCH 0/6] Vertical scrolling and another small bug fix Date: Tue, 07 Jan 2020 11:52:00 -0000 Message-Id: In-Reply-To: <874kxrc3ha.fsf@tromey.com> References: <874kxrc3ha.fsf@tromey.com> X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00139.txt.bz2 Here's a series that fixes the vertical scrolling issue. It incorporates your proposed fix (with a small testsuite change), and then builds upon it. This is a different (simpler) approach than I originally suggested. I'm still not really happy with how the tui keeps track and displays the current symtab_and_line; I think there's many places that GDB should do a better job of placing the "current" location in the centre of the screen, where currently it has a tendency to jam the current location right at the top. However, I think leaving the ability to vertically scroll broken isn't good, and I think this series is a step in the right direction (maybe?). Thoughts / comments welcome. Thanks, Andrew -- Andrew Burgess (5): gdb/testsuite/tui: Always dump_screen when asked gdb/testsuite/tui: Split enter_tui into two procs gdb/testsuite/tui: Introduce check_box_contents gdb/tui: Fix 'layout asm' before the inferior has started gdb/tui: Link source and assembler scrolling .... again Tom Tromey (1): gdb: Fix scrolling in TUI gdb/ChangeLog | 17 ++++++++ gdb/testsuite/ChangeLog | 30 ++++++++++++++ gdb/testsuite/gdb.tui/basic.exp | 40 +++++++++++++++++++ gdb/testsuite/gdb.tui/tui-layout-asm.exp | 34 ++++++++++++++++ gdb/testsuite/lib/tuiterm.exp | 67 ++++++++++++++++++++++++++------ gdb/tui/tui-source.c | 27 +++++++------ gdb/tui/tui.c | 10 +++-- 7 files changed, 199 insertions(+), 26 deletions(-) create mode 100644 gdb/testsuite/gdb.tui/tui-layout-asm.exp -- 2.14.5